This is an archive of the discontinued LLVM Phabricator instance.

AArch4: Fix range loop contradicting comment above it
ClosedPublic

Authored by arsenm on Jun 13 2016, 1:39 PM.

Details

Reviewers
john.brawn

Diff Detail

Event Timeline

arsenm updated this revision to Diff 60598.Jun 13 2016, 1:39 PM
arsenm retitled this revision from to AArch4: Fix range loop contradicting comment above it.
arsenm updated this object.
arsenm added a subscriber: llvm-commits.
john.brawn accepted this revision.Jun 16 2016, 7:58 AM
john.brawn added a reviewer: john.brawn.
john.brawn added a subscriber: john.brawn.

It's possible that the blocks that are created end up never needing branch relaxation in which case not updating end() doesn't matter, but it's not clear from a quick look if that's true or not and just doing what the comment says seems perfectly reasonable. LGTM.

This revision is now accepted and ready to land.Jun 16 2016, 7:58 AM
arsenm closed this revision.Jun 16 2016, 2:28 PM

r272959