This is an archive of the discontinued LLVM Phabricator instance.

Fix AAResults::callCapturesBefore for operand bundles
ClosedPublic

Authored by carnaval on Jun 13 2016, 6:46 AM.

Details

Summary

AAResults::callCapturesBefore would previously ignore operand bundles. It was possible for a later instruction to miss its memory dependency on a call site that would only access the pointer through a bundle.

Diff Detail

Event Timeline

carnaval updated this revision to Diff 60514.Jun 13 2016, 6:46 AM
carnaval retitled this revision from to Fix AAResults::callCapturesBefore for statepoints.
carnaval updated this object.
carnaval added a reviewer: sanjoy.
carnaval retitled this revision from Fix AAResults::callCapturesBefore for statepoints to Fix AAResults::callCapturesBefore for operand bundles.
sanjoy requested changes to this revision.Jun 13 2016, 10:24 AM
sanjoy edited edge metadata.

Can you please add a line or two in the commit message describing the problem and the fix?

test/CodeGen/X86/statepoint-memdep.ll
1

You don't need the 2>&1.

5

Add a CHECK-LABEL: @f( to make it easier to add new tests later.

This revision now requires changes to proceed.Jun 13 2016, 10:24 AM
carnaval updated this revision to Diff 60563.Jun 13 2016, 11:05 AM
carnaval updated this object.
carnaval edited edge metadata.

address comments

sanjoy accepted this revision.Jun 13 2016, 11:14 AM
sanjoy edited edge metadata.

lgtm, do you want me to commit this for you?

This revision is now accepted and ready to land.Jun 13 2016, 11:14 AM

yep, I don't have commit access. Thanks for the review !

This revision was automatically updated to reflect the committed changes.