This is an archive of the discontinued LLVM Phabricator instance.

Differential D21213

[libcxx] Add possibility to link with libunwind
Needs ReviewPublic

Authored by Eugene.Zelenko on Jun 9 2016, 4:44 PM.

Details

Reviewers
mclow.lists
EricWF
Summary

LIBCXX_USE_LLVM_UNWINDER should be also used in test/lit.site.cfg.in, but somehow I got next error during regressions when it was set to ON.

lit.py: config.py:90: fatal: parameter 'llvm_unwinder' should be true or false

Regressions on RHEL 6 were OK.

But somehow gcc_s.so is still linked implicitly (I checked link command line with -v).

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko updated this revision to Diff 60278.Jun 9 2016, 4:44 PM
Eugene.Zelenko retitled this revision from to [libcxx] Add possibility to link with libunwind.
Eugene.Zelenko updated this object.
Eugene.Zelenko added reviewers: EricWF, mclow.lists.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko updated this object.
Eugene.Zelenko added a subscriber: llvm-commits.

Revision Contents

PathSize
2 lines
cmake/
4 lines
lib/
1 line

Diff 60278

CMakeLists.txt

Context not available.
# Build libc++abi with libunwind. We need this option to determine whether to # Build libc++abi with libunwind. We need this option to determine whether to
# link with libunwind or libgcc_s while running the test cases. # link with libunwind or libgcc_s while running the test cases.
option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF) option(LIBCXX_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF)
# Target options -------------------------------------------------------------- # Target options --------------------------------------------------------------
option(LIBCXX_BUILD_32_BITS "Build 32 bit libc++." ${LLVM_BUILD_32_BITS}) option(LIBCXX_BUILD_32_BITS "Build 32 bit libc++." ${LLVM_BUILD_32_BITS})
Context not available.

cmake/config-ix.cmake

Context not available.
check_library_exists(c fopen "" LIBCXX_HAS_C_LIB) check_library_exists(c fopen "" LIBCXX_HAS_C_LIB)
check_library_exists(m ccos "" LIBCXX_HAS_M_LIB) check_library_exists(m ccos "" LIBCXX_HAS_M_LIB)
check_library_exists(rt clock_gettime "" LIBCXX_HAS_RT_LIB) check_library_exists(rt clock_gettime "" LIBCXX_HAS_RT_LIB)
check_library_exists(gcc_s __gcc_personality_v0 "" LIBCXX_HAS_GCC_S_LIB) if (NOT LIBCXX_USE_LLVM_UNWINDER)
check_library_exists(gcc_s __gcc_personality_v0 "" LIBCXX_HAS_GCC_S_LIB)
endif()
Context not available.

lib/CMakeLists.txt

Context not available.
add_library_flags_if(LIBCXX_HAS_RT_LIB rt) add_library_flags_if(LIBCXX_HAS_RT_LIB rt)
add_library_flags_if(LIBCXX_HAS_GCC_S_LIB gcc_s) add_library_flags_if(LIBCXX_HAS_GCC_S_LIB gcc_s)
add_library_flags_if(LIBCXX_HAS_ATOMIC_LIB atomic) add_library_flags_if(LIBCXX_HAS_ATOMIC_LIB atomic)
add_library_flags_if(LIBCXX_USE_LLVM_UNWINDER unwind)
# Setup flags. # Setup flags.
add_flags_if_supported(-fPIC) add_flags_if_supported(-fPIC)
Context not available.