clang-rename: implement renaming of classes inside dynamic_cast

[vmiklos]

Summary

Refactor to do the same as what is done already for static_cast.

[klimek]

lg

[vmiklos]

Hmm, http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332/steps/test/logs/stdio fails with "error: cannot use dynamic_cast with -fno-rtti"; is there some way to detect if "-fno-rtti" is the default, and in that case don't execute the test? Thanks.

[vmiklos]

Possible solution posted as http://reviews.llvm.org/D21186.

clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp

if (getUSRForDecl(Decl) == USR) {
       // This takes care of 'new <name>' expressions.
       LocationsFound.push_back(Expr->getLocation());
     }
 
     return true;
   }
 
   bool VisitCXXStaticCastExpr(clang::CXXStaticCastExpr *Expr) {
-    clang::QualType Type = Expr->getType();
-    // See if this a cast of a pointer.
-    const RecordDecl* Decl = Type->getPointeeCXXRecordDecl();
-    if (!Decl) {
-      // See if this is a cast of a reference.
-      Decl = Type->getAsCXXRecordDecl();
-    }
-
-    if (Decl && getUSRForDecl(Decl) == USR) {
-      SourceLocation Location = Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc();
-      LocationsFound.push_back(Location);
-    }
+    return handleCXXNamedCastExpr(Expr);
 
-    return true;
+  bool VisitCXXDynamicCastExpr(clang::CXXDynamicCastExpr *Expr) {
+    return handleCXXNamedCastExpr(Expr);
   }
 
   // Non-visitors:
 
   // \brief Returns a list of unique locations. Duplicate or overlapping
   // locations are erroneous and should be reported!
   const std::vector<clang::SourceLocation> &getLocationsFound() const {
     return LocationsFound;
   }
 
 private:
   // Namespace traversal:
   void checkNestedNameSpecifierLoc(NestedNameSpecifierLoc NameLoc) {
     while (NameLoc) {
       const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
       if (Decl && getUSRForDecl(Decl) == USR)
         LocationsFound.push_back(NameLoc.getLocalBeginLoc());
       NameLoc = NameLoc.getPrefix();
     }
   }
 
+  bool handleCXXNamedCastExpr(clang::CXXNamedCastExpr *Expr) {
+    clang::QualType Type = Expr->getType();
+    // See if this a cast of a pointer.
+    const RecordDecl* Decl = Type->getPointeeCXXRecordDecl();
+    if (!Decl) {
+      // See if this is a cast of a reference.
+      Decl = Type->getAsCXXRecordDecl();
+    }
+
+    if (Decl && getUSRForDecl(Decl) == USR) {
+      SourceLocation Location = Expr->getTypeInfoAsWritten()->getTypeLoc().getBeginLoc();
+      LocationsFound.push_back(Location);
+    }
+
+    return true;
+  }
+
   // All the locations of the USR were found.
   const std::string USR;
   // Old name that is renamed.
   const std::string PrevName;
   std::vector<clang::SourceLocation> LocationsFound;
 };
 } // namespace
 

clang-tools-extra/trunk/test/clang-rename/DynamicCastExpr.cpp

+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=186 -new-name=X %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+class Base {
+  virtual int getValue() const = 0;
+};
+
+class Derived : public Base {
+public:
+  int getValue() const {
+    return 0;
+  }
+};
+
+int main() {
+  Derived D;
+  const Base &Reference = D;
+  const Base *Pointer = &D;
+
+  dynamic_cast<const Derived &>(Reference).getValue(); // CHECK: dynamic_cast<const X &>
+  dynamic_cast<const Derived *>(Pointer)->getValue();  // CHECK: dynamic_cast<const X *>
+}
+
+// Use grep -FUbo 'Derived' <file> to get the correct offset of foo when changing
+// this file.