This is an archive of the discontinued LLVM Phabricator instance.

[profile] Fix a profile runtime build bug for darwin
ClosedPublic

Authored by davidxl on Jun 7 2016, 10:23 PM.

Details

Summary

EXTRA_FLAGS was never passed to rt build for darwin. This means HAS_ATOMICS and HAS_FCTNL macros were not properly set for darwin runtime build -- end up with build using stub functions.

Also getpid() requires including <unistd.h> on darwin too.

Diff Detail

Repository
rL LLVM

Event Timeline

davidxl updated this revision to Diff 59998.Jun 7 2016, 10:23 PM
davidxl retitled this revision from to [profile] Fix a profile runtime build bug for darwin.
davidxl updated this object.
davidxl added a reviewer: vsk.
davidxl added a subscriber: llvm-commits.
vsk accepted this revision.Jun 8 2016, 9:04 AM
vsk edited edge metadata.

Thanks for catching this!

This revision is now accepted and ready to land.Jun 8 2016, 9:04 AM
This revision was automatically updated to reflect the committed changes.