This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Remove incorrect assertion
ClosedPublic

Authored by arsenm on Jun 3 2016, 12:36 PM.

Reviewers

• tstellarAMD

Summary

I'm still not sure under what circumstances the offset here is non-0,
but private memory is not limited to 27-bits.

arsenm retitled this revision from to AMDGPU: Remove incorrect assertion.

arsenm updated this object.

arsenm added a subscriber: llvm-commits.

LGTM.

This revision is now accepted and ready to land.Jun 9 2016, 1:17 PM

r272337

Path

Size

lib/

Target/

AMDGPU/

4 lines

Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Lines	void SIRegisterInfo::materializeFrameBaseRegister(MachineBasicBlock *MBB,

if (Ins != MBB->end())		if (Ins != MBB->end())
DL = Ins->getDebugLoc();		DL = Ins->getDebugLoc();

MachineFunction *MF = MBB->getParent();		MachineFunction *MF = MBB->getParent();
const AMDGPUSubtarget &Subtarget = MF->getSubtarget<AMDGPUSubtarget>();		const AMDGPUSubtarget &Subtarget = MF->getSubtarget<AMDGPUSubtarget>();
const TargetInstrInfo *TII = Subtarget.getInstrInfo();		const TargetInstrInfo *TII = Subtarget.getInstrInfo();

assert(isUInt<27>(Offset) &&
"Private offset should never exceed maximum private size");


if (Offset == 0) {		if (Offset == 0) {
BuildMI(*MBB, Ins, DL, TII->get(AMDGPU::V_MOV_B32_e32), BaseReg)		BuildMI(*MBB, Ins, DL, TII->get(AMDGPU::V_MOV_B32_e32), BaseReg)
.addFrameIndex(FrameIdx);		.addFrameIndex(FrameIdx);
return;		return;
}		}

MachineRegisterInfo &MRI = MF->getRegInfo();		MachineRegisterInfo &MRI = MF->getRegInfo();
unsigned UnusedCarry = MRI.createVirtualRegister(&AMDGPU::SReg_64RegClass);		unsigned UnusedCarry = MRI.createVirtualRegister(&AMDGPU::SReg_64RegClass);
▲ Show 20 Lines • Show All 704 Lines • Show Last 20 Lines