This is an archive of the discontinued LLVM Phabricator instance.

Differential D20963

[mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.
ClosedPublic

Authored by dsanders on Jun 3 2016, 7:38 AM.

Details

Reviewers
atanasyan
Commits
rG28d8637e256e: [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.
rC271877: [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.
rL271877: [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.
Summary

Depends on D20961

Diff Detail

Event Timeline

dsanders updated this revision to Diff 59554.Jun 3 2016, 7:38 AM
dsanders retitled this revision from to [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU..
dsanders updated this object.
dsanders added a reviewer: atanasyan.
dsanders added a parent revision: D20961: [mips] Replace almost all Arch checks in MipsTargetInfo with ABI checks. NFC..
dsanders added a subscriber: cfe-commits.
Herald added a subscriber: sdardis. · View Herald TranscriptJun 3 2016, 7:38 AM
atanasyan accepted this revision.Jun 3 2016, 8:33 AM
atanasyan edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 3 2016, 8:33 AM
dsanders closed this revision.Jun 6 2016, 2:54 AM

Revision Contents

PathSize
lib/
Basic/
2 lines
test/
Driver/
5 lines

Diff 59554

lib/Basic/Targets.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 7,164 Lines • ▼ Show 20 Lines return llvm::StringSwitch<bool>(Name)
.Case("mips32r5", !GPR64Required) .Case("mips32r5", !GPR64Required)
.Case("mips32r6", !GPR64Required) .Case("mips32r6", !GPR64Required)
.Case("mips64", true) .Case("mips64", true)
.Case("mips64r2", true) .Case("mips64r2", true)
.Case("mips64r3", true) .Case("mips64r3", true)
.Case("mips64r5", true) .Case("mips64r5", true)
.Case("mips64r6", true) .Case("mips64r6", true)
.Case("octeon", true) .Case("octeon", true)
.Case("p5600", true) .Case("p5600", !GPR64Required)
.Default(false); .Default(false);
} }
const std::string& getCPU() const { return CPU; } const std::string& getCPU() const { return CPU; }
bool bool
initFeatureMap(llvm::StringMap<bool> &Features, DiagnosticsEngine &Diags, initFeatureMap(llvm::StringMap<bool> &Features, DiagnosticsEngine &Diags,
StringRef CPU, StringRef CPU,
const std::vector<std::string> &FeaturesVec) const override { const std::vector<std::string> &FeaturesVec) const override {
if (CPU.empty()) if (CPU.empty())
▲ Show 20 Lines • Show All 1,258 Lines • Show Last 20 Lines

test/Driver/mips-abi.c

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
// MIPS-ARCH-32R2: "-target-abi" "o32" // MIPS-ARCH-32R2: "-target-abi" "o32"
// //
// RUN: %clang -target mips-linux-gnu -### -c %s \ // RUN: %clang -target mips-linux-gnu -### -c %s \
// RUN: -march=p5600 2>&1 \ // RUN: -march=p5600 2>&1 \
// RUN: | FileCheck -check-prefix=MIPS-ARCH-P5600 %s // RUN: | FileCheck -check-prefix=MIPS-ARCH-P5600 %s
// MIPS-ARCH-P5600: "-target-cpu" "p5600" // MIPS-ARCH-P5600: "-target-cpu" "p5600"
// MIPS-ARCH-P5600: "-target-abi" "o32" // MIPS-ARCH-P5600: "-target-abi" "o32"
// //
// RUN: not %clang -target mips-linux-gnu -c %s \
// RUN: -march=p5600 -mabi=64 2>&1 \
// RUN: | FileCheck -check-prefix=MIPS-ARCH-P5600-N64 %s
// MIPS-ARCH-P5600-N64: error: unknown target ABI 'n64'
//
// RUN: %clang -target mips-linux-gnu -### -c %s \ // RUN: %clang -target mips-linux-gnu -### -c %s \
// RUN: -march=mips64 2>&1 \ // RUN: -march=mips64 2>&1 \
// RUN: | FileCheck -check-prefix=MIPS-ARCH-3264 %s // RUN: | FileCheck -check-prefix=MIPS-ARCH-3264 %s
// MIPS-ARCH-3264: "-target-cpu" "mips64" // MIPS-ARCH-3264: "-target-cpu" "mips64"
// MIPS-ARCH-3264: "-target-abi" "o32" // MIPS-ARCH-3264: "-target-abi" "o32"
// //
// RUN: %clang -target mips64-linux-gnu -### -c %s \ // RUN: %clang -target mips64-linux-gnu -### -c %s \
// RUN: -march=mips64 2>&1 \ // RUN: -march=mips64 2>&1 \
Show All 25 Lines