This is an archive of the discontinued LLVM Phabricator instance.

[LibFuzzer] Provide stub implementation of __sanitizer_cov_trace_pc_indir
ClosedPublic

Authored by delcypher on Jun 2 2016, 8:38 PM.

Details

Summary

[LibFuzzer] Provide stub implementation of __sanitizer_cov_trace_pc_indir

Calls to this function are currently injected by the
`SanitizerCoverageModule pass when the both the indirect-calls`
and `trace-pc` sanitizer coverage options are enabled and the code
being instrumented has indirect calls. Previously because LibFuzzer did
not define this function this would lead to link errors when building
some of the tests on OSX.

This combined with http://reviews.llvm.org/D20943 is enough to fix compilation of the LibFuzzer tests on OSX.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher updated this revision to Diff 59488.Jun 2 2016, 8:38 PM
delcypher retitled this revision from to [LibFuzzer] Provide stub implementation of __sanitizer_cov_trace_pc_indir.
delcypher updated this object.
delcypher added reviewers: kcc, aizatsky.
delcypher added subscribers: kcc, aizatsky, zaks.anna and 3 others.
kcc accepted this revision.Jun 3 2016, 1:57 PM
kcc edited edge metadata.

Add something like "currently not used " to the comment.

This revision is now accepted and ready to land.Jun 3 2016, 1:57 PM
This revision was automatically updated to reflect the committed changes.