This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix incorrectly setting kill flag when copying register tuples
ClosedPublic

Authored by arsenm on Jun 1 2016, 10:46 AM.

Reviewers

• tstellarAMD
nhaehnle

Summary

This fixes some verifier errors when trackLivenessAfterRegAlloc is enabled.

arsenm retitled this revision from to AMDGPU: Fix incorrectly setting kill flag when copying register tuples.

arsenm updated this object.

arsenm added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Jun 1 2016, 12:34 PM

r271446

Path

Size

lib/

Target/

AMDGPU/

2 lines

Show First 20 Lines • Show All 481 Lines • ▼ Show 20 Lines	else
SubIdx = SubIndices[SubIndices.size() - Idx - 1];		SubIdx = SubIndices[SubIndices.size() - Idx - 1];

MachineInstrBuilder Builder = BuildMI(MBB, MI, DL,		MachineInstrBuilder Builder = BuildMI(MBB, MI, DL,
get(Opcode), RI.getSubReg(DestReg, SubIdx));		get(Opcode), RI.getSubReg(DestReg, SubIdx));

Builder.addReg(RI.getSubReg(SrcReg, SubIdx));		Builder.addReg(RI.getSubReg(SrcReg, SubIdx));

if (Idx == SubIndices.size() - 1)		if (Idx == SubIndices.size() - 1)
Builder.addReg(SrcReg, RegState::Kill \| RegState::Implicit);		Builder.addReg(SrcReg, getKillRegState(KillSrc) \| RegState::Implicit);

if (Idx == 0)		if (Idx == 0)
Builder.addReg(DestReg, RegState::Define \| RegState::Implicit);		Builder.addReg(DestReg, RegState::Define \| RegState::Implicit);
}		}
}		}

int SIInstrInfo::commuteOpcode(const MachineInstr &MI) const {		int SIInstrInfo::commuteOpcode(const MachineInstr &MI) const {
const unsigned Opcode = MI.getOpcode();		const unsigned Opcode = MI.getOpcode();
▲ Show 20 Lines • Show All 2,687 Lines • Show Last 20 Lines