This is an archive of the discontinued LLVM Phabricator instance.

Differential D20826

[CMake] Update to retiring CMake 3.4.3
ClosedPublic

Authored by beanz on May 31 2016, 11:15 AM.

Details

Reviewers
zturner
Commits
rGc12cabb4f4b5: [CMake] Update to requiring CMake 3.4.3
rLLDB271328: [CMake] Update to requiring CMake 3.4.3
rL271328: [CMake] Update to requiring CMake 3.4.3
Summary

This is as per the discussions on developer lists:

http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 59096.May 31 2016, 11:15 AM
beanz retitled this revision from to [CMake] Update to retiring CMake 3.4.3.
beanz updated this object.
beanz added a subscriber: lldb-commits.
zturner accepted this revision.May 31 2016, 11:22 AM
zturner added a reviewer: zturner.
This revision is now accepted and ready to land.May 31 2016, 11:22 AM
Closed by commit rL271328: [CMake] Update to requiring CMake 3.4.3 (authored by cbieneman). · Explain WhyMay 31 2016, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
2 lines

Diff 59124

lldb/trunk/CMakeLists.txt

cmake_minimum_required(VERSION 2.8.12.2) cmake_minimum_required(VERSION 3.4.3)
include(cmake/modules/LLDBStandalone.cmake) include(cmake/modules/LLDBStandalone.cmake)
include(cmake/modules/LLDBConfig.cmake) include(cmake/modules/LLDBConfig.cmake)
include(cmake/modules/AddLLDB.cmake) include(cmake/modules/AddLLDB.cmake)
if (__ANDROID_NDK__ OR (CMAKE_SYSTEM_NAME MATCHES "Windows")) if (__ANDROID_NDK__ OR (CMAKE_SYSTEM_NAME MATCHES "Windows"))
set(LLDB_DEFAULT_DISABLE_LIBEDIT 1) set(LLDB_DEFAULT_DISABLE_LIBEDIT 1)
else() else()
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines