This is an archive of the discontinued LLVM Phabricator instance.

Paths

[clang-tidy] Fix script adding new clang-tidy check
ClosedPublic

Authored by etienneb on May 27 2016, 8:19 PM.

Reviewers

alexfh

Commits

Summary

The getName() call is useless. It's better to show a better example
as tutorial.

etienneb retitled this revision from to [clang-tidy] Fix script adding new clang-tidy check.

etienneb updated this object.

etienneb added a reviewer: alexfh.

etienneb added a subscriber: cfe-commits.

This revision is now accepted and ready to land.May 27 2016, 11:42 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang-tools-extra/

trunk/

clang-tidy/

2 lines

	Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
	}			}

	void %(check_name)s::check(const MatchFinder::MatchResult &Result) {			void %(check_name)s::check(const MatchFinder::MatchResult &Result) {
	// FIXME: Add callback implementation.			// FIXME: Add callback implementation.
	const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("x");			const auto *MatchedDecl = Result.Nodes.getNodeAs<FunctionDecl>("x");
	if (MatchedDecl->getName().startswith("awesome_"))			if (MatchedDecl->getName().startswith("awesome_"))
	return;			return;
	diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome")			diag(MatchedDecl->getLocation(), "function '%%0' is insufficiently awesome")
	<< MatchedDecl->getName()			<< MatchedDecl
	<< FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_");			<< FixItHint::CreateInsertion(MatchedDecl->getLocation(), "awesome_");
	}			}

	} // namespace %(module)s			} // namespace %(module)s
	} // namespace tidy			} // namespace tidy
	} // namespace clang			} // namespace clang
	""" % {'check_name': check_name_camel,			""" % {'check_name': check_name_camel,
	'module': module})			'module': module})
	▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines