This is an archive of the discontinued LLVM Phabricator instance.

Differential D20336

[AMDGPU] Remove individual debugger options + update features
ClosedPublic

Authored by kzhuravl on May 17 2016, 1:54 PM.

Details

Reviewers
• tstellarAMD
arsenm
Commits
rGe6dbd902c082: [AMDGPU] Remove individual debugger options + update features
rC270895: [AMDGPU] Remove individual debugger options + update features
rL270895: [AMDGPU] Remove individual debugger options + update features

Diff Detail

Repository
rL LLVM

Event Timeline

kzhuravl updated this revision to Diff 57516.May 17 2016, 1:54 PM
kzhuravl retitled this revision from to [AMDGPU] Remove individual debugger options.
kzhuravl updated this object.
kzhuravl added a reviewer: arsenm.
kzhuravl added subscribers: whchung, cfe-commits.
Herald added a reviewer: • tstellarAMD. · View Herald TranscriptMay 17 2016, 1:54 PM
Herald added a subscriber: kzhuravl. · View Herald Transcript
kzhuravl updated this revision to Diff 57518.May 17 2016, 2:20 PM
kzhuravl retitled this revision from [AMDGPU] Remove individual debugger options to [AMDGPU] Remove individual debugger options + update features.
kzhuravl edited edge metadata.

Update features

kzhuravl added a comment.May 23 2016, 8:37 AM

Ping

• tstellarAMD accepted this revision.May 25 2016, 6:41 PM
• tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.May 25 2016, 6:41 PM
Closed by commit rL270895: [AMDGPU] Remove individual debugger options + update features (authored by kzhuravl). · Explain WhyMay 26 2016, 12:43 PM
This revision was automatically updated to reflect the committed changes.
kzhuravl added a comment.May 26 2016, 12:43 PM

rL270895

Revision Contents

PathSize
cfe/
trunk/
include/
clang/
Driver/
4 lines
lib/
Driver/
3 lines
test/
Driver/
18 lines

Diff 58668

cfe/trunk/include/clang/Driver/Options.td

Show First 20 Lines • Show All 1,469 Lines • ▼ Show 20 Lines
def msimd128 : Flag<["-"], "msimd128">, Group<m_wasm_Features_Group>; def msimd128 : Flag<["-"], "msimd128">, Group<m_wasm_Features_Group>;
def mno_simd128 : Flag<["-"], "mno-simd128">, Group<m_wasm_Features_Group>; def mno_simd128 : Flag<["-"], "mno-simd128">, Group<m_wasm_Features_Group>;
def mamdgpu_debugger_abi : Joined<["-"], "mamdgpu-debugger-abi=">, def mamdgpu_debugger_abi : Joined<["-"], "mamdgpu-debugger-abi=">,
Flags<[HelpHidden]>, Flags<[HelpHidden]>,
Group<m_Group>, Group<m_Group>,
HelpText<"Generate additional code for specified <version> of debugger ABI (AMDGPU only)">, HelpText<"Generate additional code for specified <version> of debugger ABI (AMDGPU only)">,
MetaVarName<"<version>">; MetaVarName<"<version>">;
def mamdgpu_debugger_insert_nops : Flag<["-"], "mamdgpu-debugger-insert-nops">,
Group<m_amdgpu_Features_Group>;
def mamdgpu_debugger_reserve_trap_regs : Flag<["-"], "mamdgpu-debugger-reserve-trap-regs">,
Group<m_amdgpu_Features_Group>;
def mvsx : Flag<["-"], "mvsx">, Group<m_ppc_Features_Group>; def mvsx : Flag<["-"], "mvsx">, Group<m_ppc_Features_Group>;
def mno_vsx : Flag<["-"], "mno-vsx">, Group<m_ppc_Features_Group>; def mno_vsx : Flag<["-"], "mno-vsx">, Group<m_ppc_Features_Group>;
def mpower8_vector : Flag<["-"], "mpower8-vector">, def mpower8_vector : Flag<["-"], "mpower8-vector">,
Group<m_ppc_Features_Group>; Group<m_ppc_Features_Group>;
def mno_power8_vector : Flag<["-"], "mno-power8-vector">, def mno_power8_vector : Flag<["-"], "mno-power8-vector">,
Group<m_ppc_Features_Group>; Group<m_ppc_Features_Group>;
def mpower8_crypto : Flag<["-"], "mcrypto">, def mpower8_crypto : Flag<["-"], "mcrypto">,
▲ Show 20 Lines • Show All 726 Lines • Show Last 20 Lines

cfe/trunk/lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,457 Lines • ▼ Show 20 Lines
} }
static void getAMDGPUTargetFeatures(const Driver &D, const ArgList &Args, static void getAMDGPUTargetFeatures(const Driver &D, const ArgList &Args,
std::vector<const char *> &Features) { std::vector<const char *> &Features) {
if (const Arg *dAbi = Args.getLastArg(options::OPT_mamdgpu_debugger_abi)) { if (const Arg *dAbi = Args.getLastArg(options::OPT_mamdgpu_debugger_abi)) {
StringRef value = dAbi->getValue(); StringRef value = dAbi->getValue();
if (value == "1.0") { if (value == "1.0") {
Features.push_back("+amdgpu-debugger-insert-nops"); Features.push_back("+amdgpu-debugger-insert-nops");
Features.push_back("+amdgpu-debugger-reserve-trap-regs"); Features.push_back("+amdgpu-debugger-reserve-regs");
Features.push_back("+amdgpu-debugger-emit-prologue");
} else { } else {
D.Diag(diag::err_drv_clang_unsupported) << dAbi->getAsString(Args); D.Diag(diag::err_drv_clang_unsupported) << dAbi->getAsString(Args);
} }
} }
handleTargetFeaturesGroup( handleTargetFeaturesGroup(
Args, Features, options::OPT_m_amdgpu_Features_Group); Args, Features, options::OPT_m_amdgpu_Features_Group);
} }
▲ Show 20 Lines • Show All 8,608 Lines • Show Last 20 Lines

cfe/trunk/test/Driver/amdgpu-features.c

// Check handling of AMDGPU target features.
//
// -mamdgpu-debugger-abi=0.0
// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=0.0 %s -o 2>&1 \ // RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=0.0 %s -o 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-0-0 %s // RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-0-0 %s
// CHECK-MAMDGPU-DEBUGGER-ABI-0-0: the clang compiler does not support '-mamdgpu-debugger-abi=0.0' // CHECK-MAMDGPU-DEBUGGER-ABI-0-0: the clang compiler does not support '-mamdgpu-debugger-abi=0.0'
//
// -mamdgpu-debugger-abi=1.0
// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=1.0 %s -o 2>&1 \ // RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-abi=1.0 %s -o 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-1-0 %s // RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-ABI-1-0 %s
// CHECK-MAMDGPU-DEBUGGER-ABI-1-0: "-target-feature" "+amdgpu-debugger-insert-nops" "-target-feature" "+amdgpu-debugger-reserve-trap-regs" // CHECK-MAMDGPU-DEBUGGER-ABI-1-0: "-target-feature" "+amdgpu-debugger-insert-nops" "-target-feature" "+amdgpu-debugger-reserve-regs" "-target-feature" "+amdgpu-debugger-emit-prologue"
//
// -mamdgpu-debugger-insert-nops
// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-insert-nops %s -o 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-INSERT-NOPS %s
// CHECK-MAMDGPU-DEBUGGER-INSERT-NOPS: "-target-feature" "+amdgpu-debugger-insert-nops"
//
// -mamdgpu-debugger-reserve-trap-regs
// RUN: %clang -### -target amdgcn -x cl -S -emit-llvm -mcpu=kaveri -mamdgpu-debugger-reserve-trap-regs %s -o 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-MAMDGPU-DEBUGGER-RESERVE-TRAP-REGS %s
// CHECK-MAMDGPU-DEBUGGER-RESERVE-TRAP-REGS: "-target-feature" "+amdgpu-debugger-reserve-trap-regs"