This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Allow dlopen/dlclose interception to be disabled from cmake
ClosedPublic

Authored by fjricci on May 17 2016, 10:34 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci updated this revision to Diff 57499.May 17 2016, 10:34 AM
fjricci retitled this revision from to [sanitizer] Allow dlopen/dlclose interception to be disabled from cmake.
fjricci updated this object.
fjricci added subscribers: llvm-commits, compnerd.
filcab added a subscriber: filcab.May 17 2016, 10:37 AM

I think it should be documented somewhere that defining SANITIZER_INTERCEPT_DLOPEN_DLCLOSE allows people to change the default behavior.

Any suggestions on where to document it? I wasn't able to find documentation for similar defines (ie SANITIZER_INTERCEPT_PRINTF).

kcc accepted this revision.May 17 2016, 3:59 PM
kcc added a reviewer: kcc.
kcc added a subscriber: kcc.

LGTM
I don't think we have a place to document this better than the code itself.

This revision is now accepted and ready to land.May 17 2016, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Indeed, no good place to document it :-(

Thanks for working on this!

Filipe