This is an archive of the discontinued LLVM Phabricator instance.

Differential D20169

[ELF] implemented -z defs option
ClosedPublic

Authored by grimar on May 11 2016, 6:49 AM.

Details

Reviewers
ruiu
• rafael
Commits
rGfa91000290d0: [ELF] implemented -z defs option
rLLD269183: [ELF] implemented -z defs option
rL269183: [ELF] implemented -z defs option
Summary

Just do not allow to link shared library if there are
undefined symbols.

This fixes PR27447

Diff Detail

Repository
rL LLVM

Event Timeline

grimar updated this revision to Diff 56902.May 11 2016, 6:49 AM
grimar retitled this revision from to [ELF] implemented -z defs option.
grimar updated this object.
grimar added reviewers: ruiu, • rafael.
grimar added subscribers: grimar, llvm-commits.
• rafael edited edge metadata.May 11 2016, 6:50 AM
• rafael added a subscriber: • rafael.

LGTM. Thanks!

Closed by commit rL269183: [ELF] implemented -z defs option (authored by grimar). · Explain WhyMay 11 2016, 6:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
trunk/
ELF/
1 line
1 line
2 lines
test/
ELF/
7 lines

Diff 56904

lld/trunk/ELF/Config.h

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Linesstruct Configuration {
bool StripDebug; bool StripDebug;
bool SysvHash = true; bool SysvHash = true;
bool Threads; bool Threads;
bool Trace; bool Trace;
bool Verbose; bool Verbose;
bool VersionScript = false; bool VersionScript = false;
bool WarnCommon; bool WarnCommon;
bool ZCombreloc; bool ZCombreloc;
bool ZDefs;
bool ZExecStack; bool ZExecStack;
bool ZNodelete; bool ZNodelete;
bool ZNow; bool ZNow;
bool ZOrigin; bool ZOrigin;
bool ZRelro; bool ZRelro;
BuildIdKind BuildId = BuildIdKind::None; BuildIdKind BuildId = BuildIdKind::None;
ELFKind EKind = ELFNoneKind; ELFKind EKind = ELFNoneKind;
uint16_t EMachine = llvm::ELF::EM_NONE; uint16_t EMachine = llvm::ELF::EM_NONE;
Show All 13 Lines

lld/trunk/ELF/Driver.cpp

Show First 20 Lines • Show All 347 Lines • ▼ Show 20 Linesvoid LinkerDriver::readConfigs(opt::InputArgList &Args) {
Config->LtoO = getInteger(Args, OPT_lto_O, 2); Config->LtoO = getInteger(Args, OPT_lto_O, 2);
if (Config->LtoO > 3) if (Config->LtoO > 3)
error("invalid optimization level for LTO: " + getString(Args, OPT_lto_O)); error("invalid optimization level for LTO: " + getString(Args, OPT_lto_O));
Config->LtoJobs = getInteger(Args, OPT_lto_jobs, 1); Config->LtoJobs = getInteger(Args, OPT_lto_jobs, 1);
if (Config->LtoJobs == 0) if (Config->LtoJobs == 0)
error("number of threads must be > 0"); error("number of threads must be > 0");
Config->ZCombreloc = !hasZOption(Args, "nocombreloc"); Config->ZCombreloc = !hasZOption(Args, "nocombreloc");
Config->ZDefs = hasZOption(Args, "defs");
Config->ZExecStack = hasZOption(Args, "execstack"); Config->ZExecStack = hasZOption(Args, "execstack");
Config->ZNodelete = hasZOption(Args, "nodelete"); Config->ZNodelete = hasZOption(Args, "nodelete");
Config->ZNow = hasZOption(Args, "now"); Config->ZNow = hasZOption(Args, "now");
Config->ZOrigin = hasZOption(Args, "origin"); Config->ZOrigin = hasZOption(Args, "origin");
Config->ZRelro = !hasZOption(Args, "norelro"); Config->ZRelro = !hasZOption(Args, "norelro");
if (Config->Relocatable) if (Config->Relocatable)
Config->StripAll = false; Config->StripAll = false;
▲ Show 20 Lines • Show All 143 Lines • Show Last 20 Lines

lld/trunk/ELF/Writer.cpp

Show First 20 Lines • Show All 787 Lines • ▼ Show 20 Lines else
scanRelocs(S, EObj.rels(&RelSec)); scanRelocs(S, EObj.rels(&RelSec));
} }
template <class ELFT> template <class ELFT>
static void reportUndefined(SymbolTable<ELFT> &Symtab, SymbolBody *Sym) { static void reportUndefined(SymbolTable<ELFT> &Symtab, SymbolBody *Sym) {
if (!Config->NoUndefined) { if (!Config->NoUndefined) {
if (Config->Relocatable) if (Config->Relocatable)
return; return;
if (Config->Shared) if (Config->Shared && !Config->ZDefs)
if (Sym->symbol()->Visibility == STV_DEFAULT) if (Sym->symbol()->Visibility == STV_DEFAULT)
return; return;
} }
std::string Msg = "undefined symbol: " + Sym->getName().str(); std::string Msg = "undefined symbol: " + Sym->getName().str();
if (InputFile *File = Sym->getSourceFile<ELFT>()) if (InputFile *File = Sym->getSourceFile<ELFT>())
Msg += " in " + getFilename(File); Msg += " in " + getFilename(File);
if (Config->NoinhibitExec) if (Config->NoinhibitExec)
▲ Show 20 Lines • Show All 1,156 Lines • Show Last 20 Lines

lld/trunk/test/ELF/zdefs.s

# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
# RUN: ld.lld -shared %t.o -o %t1.so
# RUN: not ld.lld -z defs -shared %t.o -o %t1.so 2>&1 | FileCheck -check-prefix=ERR %s
# ERR: undefined symbol: foo
callq foo@PLT