This is an archive of the discontinued LLVM Phabricator instance.

Differential D20086

AMDGPU: Fix getIntegerAttribute type and error message
ClosedPublic

Authored by arsenm on May 9 2016, 3:26 PM.

Download Raw Diff

Details

Reviewers

• tstellarAMD
kzhuravl

Diff Detail

Event Timeline

arsenm updated this revision to Diff 56645.May 9 2016, 3:26 PM

arsenm retitled this revision from to AMDGPU: Fix getIntegerAttribute type and error message.

arsenm updated this object.

arsenm added a reviewer: • tstellarAMD.

arsenm added a subscriber: llvm-commits.

Herald added subscribers: kzhuravl, arsenm. · View Herald TranscriptMay 9 2016, 3:26 PM

LGTM

This revision is now accepted and ready to land.May 10 2016, 8:34 AM

r269268

Revision Contents

Path

Size

lib/

Target/

AMDGPU/

Utils/

AMDGPUBaseInfo.h

3 lines

AMDGPUBaseInfo.cpp

8 lines

Diff 56645

lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h

	Show All 39 Lines
	MCSection *getHSADataGlobalProgramSection(MCContext &Ctx);			MCSection *getHSADataGlobalProgramSection(MCContext &Ctx);

	MCSection *getHSARodataReadonlyAgentSection(MCContext &Ctx);			MCSection *getHSARodataReadonlyAgentSection(MCContext &Ctx);

	bool isGroupSegment(const GlobalValue *GV);			bool isGroupSegment(const GlobalValue *GV);
	bool isGlobalSegment(const GlobalValue *GV);			bool isGlobalSegment(const GlobalValue *GV);
	bool isReadOnlySegment(const GlobalValue *GV);			bool isReadOnlySegment(const GlobalValue *GV);

	unsigned getIntegerAttribute(const Function &F, StringRef Name,			int getIntegerAttribute(const Function &F, StringRef Name, int Default);
	unsigned Default);

	unsigned getMaximumWorkGroupSize(const Function &F);			unsigned getMaximumWorkGroupSize(const Function &F);
	unsigned getInitialPSInputAddr(const Function &F);			unsigned getInitialPSInputAddr(const Function &F);

	bool isShader(CallingConv::ID cc);			bool isShader(CallingConv::ID cc);
	bool isCompute(CallingConv::ID cc);			bool isCompute(CallingConv::ID cc);

	bool isSI(const MCSubtargetInfo &STI);			bool isSI(const MCSubtargetInfo &STI);
	Show All 11 Lines

lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp

	Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines
	bool isGlobalSegment(const GlobalValue *GV) {			bool isGlobalSegment(const GlobalValue *GV) {
	return GV->getType()->getAddressSpace() == AMDGPUAS::GLOBAL_ADDRESS;			return GV->getType()->getAddressSpace() == AMDGPUAS::GLOBAL_ADDRESS;
	}			}

	bool isReadOnlySegment(const GlobalValue *GV) {			bool isReadOnlySegment(const GlobalValue *GV) {
	return GV->getType()->getAddressSpace() == AMDGPUAS::CONSTANT_ADDRESS;			return GV->getType()->getAddressSpace() == AMDGPUAS::CONSTANT_ADDRESS;
	}			}

	unsigned getIntegerAttribute(const Function &F, StringRef Name,			int getIntegerAttribute(const Function &F, StringRef Name, int Default) {
	unsigned Default) {
	Attribute A = F.getFnAttribute(Name);			Attribute A = F.getFnAttribute(Name);
	unsigned Result = Default;			int Result = Default;

	if (A.isStringAttribute()) {			if (A.isStringAttribute()) {
	StringRef Str = A.getValueAsString();			StringRef Str = A.getValueAsString();
	if (Str.getAsInteger(0, Result)) {			if (Str.getAsInteger(0, Result)) {
	LLVMContext &Ctx = F.getContext();			LLVMContext &Ctx = F.getContext();
	Ctx.emitError("can't parse shader type");			Ctx.emitError("can't parse integer attribute " + Name);
	}			}
	}			}

	return Result;			return Result;
	}			}

	unsigned getMaximumWorkGroupSize(const Function &F) {			unsigned getMaximumWorkGroupSize(const Function &F) {
	return getIntegerAttribute(F, "amdgpu-max-work-group-size", 256);			return getIntegerAttribute(F, "amdgpu-max-work-group-size", 256);
	}			}

	unsigned getInitialPSInputAddr(const Function &F) {			unsigned getInitialPSInputAddr(const Function &F) {
	▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines