This is an archive of the discontinued LLVM Phabricator instance.

Differential D20079

Avoid gcc warning about casting ptr-to-object to ptr-to-fun
AcceptedPublic

Authored by dougk on May 9 2016, 1:29 PM.

Details

Reviewers
zaks.anna
Summary

Use the workaround provided in the dlsym() man page.

Diff Detail

Event Timeline

dougk updated this revision to Diff 56618.May 9 2016, 1:29 PM
dougk retitled this revision from to Avoid gcc warning about casting ptr-to-object to ptr-to-fun.
dougk updated this object.
dougk added a reviewer: zaks.anna.
dougk added a subscriber: llvm-commits.
Herald added a subscriber: kubamracek. · View Herald TranscriptMay 9 2016, 1:29 PM
jroelofs added a subscriber: jroelofs.May 9 2016, 1:41 PM
jroelofs added inline comments.
lib/stats/stats_client.cc
33

IIUC, this should be written as:

void (*LookupSymbolFromMain())(const char *name) {
dougk updated this revision to Diff 56656.May 9 2016, 7:19 PM

fix declaration

zaks.anna edited edge metadata.May 9 2016, 8:18 PM

LGTM

zaks.anna accepted this revision.Jun 21 2016, 2:30 PM
zaks.anna edited edge metadata.

Should I commit or do you have commit access?

This revision is now accepted and ready to land.Jun 21 2016, 2:30 PM
jroelofs added inline comments.Jun 22 2016, 9:02 AM
lib/stats/stats_client.cc
33

erm... never mind. Confusing type is confusing.

A typedef would probably help readability here.

Revision Contents

PathSize
lib/
sanitizer_common/
4 lines
stats/
8 lines

Diff 56656

lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc

Context not available.
char *outputBuffer, char *outputBuffer,
size_t *outputBufferSize, size_t *outputBufferSize,
uint32_t flags); uint32_t flags);
swift_demangle_ft swift_demangle_f = swift_demangle_ft swift_demangle_f;
(swift_demangle_ft) dlsym(RTLD_DEFAULT, "swift_demangle"); *(void**)&swift_demangle_f = dlsym(RTLD_DEFAULT, "swift_demangle");
if (swift_demangle_f) if (swift_demangle_f)
return swift_demangle_f(name, internal_strlen(name), 0, 0, 0); return swift_demangle_f(name, internal_strlen(name), 0, 0, 0);
Context not available.

lib/stats/stats_client.cc

Context not available.
namespace { namespace {
void *LookupSymbolFromMain(const char *name) { void (*LookupSymbolFromMain(const char *name))() {
jroelofsUnsubmitted
Not Done
ReplyInline Actions

IIUC, this should be written as:

void (*LookupSymbolFromMain())(const char *name) {
jroelofs: IIUC, this should be written as: ``` void (*LookupSymbolFromMain())(const char *name) { ```
jroelofsUnsubmitted
Not Done
ReplyInline Actions

erm... never mind. Confusing type is confusing.

A typedef would probably help readability here.

jroelofs: erm... never mind. Confusing type is confusing. A typedef would probably help readability here.
#ifdef _WIN32 #ifdef _WIN32
return reinterpret_cast<void *>(GetProcAddress(GetModuleHandle(0), name)); return reinterpret_cast<void (*)()>(GetProcAddress(GetModuleHandle(0), name));
#else #else
return dlsym(RTLD_DEFAULT, name); void (*f)();
*(void**)&f = dlsym(RTLD_DEFAULT, name);
return f;
#endif #endif
} }
Context not available.