This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Explicit return in non-void function
ClosedPublic

Authored by bogden on May 6 2016, 5:08 AM.

Details

Summary

This test contains a non-void function with no explicit return,
causing it to fail when built with -Werror=return-type. This patch adds
a return to the function.

Diff Detail

Event Timeline

bogden updated this revision to Diff 56403.May 6 2016, 5:08 AM
bogden retitled this revision from to [libc++] Explicit return in non-void function.
bogden updated this object.
bogden added a reviewer: EricWF.
bogden added a subscriber: cfe-commits.
bogden added a comment.May 6 2016, 5:09 AM

I think this fix is OK, but I'm not clear on why we need both C and D, so perhaps it is important that the function does not have a return statement.

mclow.lists accepted this revision.May 12 2016, 7:34 AM
mclow.lists added a reviewer: mclow.lists.
mclow.lists added a subscriber: mclow.lists.

LGTM.

C and D are different failure modes for uses_allocator, since the standard says that it has to be a nested type.

This revision is now accepted and ready to land.May 12 2016, 7:34 AM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in r269298.