This is an archive of the discontinued LLVM Phabricator instance.

[X86] Simplify FixupBW sub_8bit_hi-related logic. NFC.
ClosedPublic

Authored by ab on May 5 2016, 6:05 PM.

Details

Summary

Instead of passing around sizes and asking for subregs, we can check the subreg indices we really care about: sub_8bit_hi and sub_8bit. WDYT?

Diff Detail

Event Timeline

ab updated this revision to Diff 56375.May 5 2016, 6:05 PM
ab retitled this revision from to [X86] Simplify FixupBW sub_8bit_hi-related logic. NFC..
ab updated this object.
ab added a reviewer: kbsmith1.
ab added a subscriber: llvm-commits.
kbsmith1 accepted this revision.May 6 2016, 9:11 AM
kbsmith1 edited edge metadata.

Nice changes. I think those greatly improve the readability.

This revision is now accepted and ready to land.May 6 2016, 9:11 AM
This revision was automatically updated to reflect the committed changes.