[NFC] Run Windows-specific code only on Windows platform

[probinson]

lib/Target/X86/X86TargetMachine.cpp

43

Isn't this a Windows-target thing? You've made it a Windows-host thing.

[kevgs]

lib/Target/X86/X86TargetMachine.cpp

43

I'm building clang on Linux, running like this clang++ foo.cc and this code executes. My thoughts is that clang++ frontend isn't meant to generate Windows code because clang-cl is meant for this puprose.

Should clang++ be able to generate Windows code?

[probinson]

lib/Target/X86/X86TargetMachine.cpp

43

clang-cl isn't meant to be the only way to produce Windows objects; it is meant to be a drop-in replacement for Microsoft cl.exe, and so *defaults* to producing Windows objects.
You can certainly specify a Windows target while running on Linux:
clang++ -target x86_64-pc-win32 foo.cc

So you don't want to use #ifdef here. If you can get your hands on the target triple, you could put this under a runtime test.

[kevgs]

lib/Target/X86/X86TargetMachine.cpp

43

Ok. That means my patch have no sense. Thanks for your time!

lib/Target/X86/X86TargetMachine.cpp

 void initializeWinEHStatePassPass(PassRegistry &);
 }
 
 extern "C" void LLVMInitializeX86Target() {
   // Register the target.
   RegisterTargetMachine<X86TargetMachine> X(TheX86_32Target);
   RegisterTargetMachine<X86TargetMachine> Y(TheX86_64Target);
 
+#ifdef WIN32
   PassRegistry &PR = *PassRegistry::getPassRegistry();
   initializeWinEHStatePassPass(PR);
+#endif
 }
 
 static std::unique_ptr<TargetLoweringObjectFile> createTLOF(const Triple &TT) {
   if (TT.isOSBinFormatMachO()) {
     if (TT.getArch() == Triple::x86_64)
       return make_unique<X86_64MachoTargetObjectFile>();
     return make_unique<TargetLoweringObjectFileMachO>();
   }