Page MenuHomePhabricator

Split out console and file writing cases in TestCommandScriptImmediateOutput
ClosedPublic

Authored by fjricci on Apr 28 2016, 2:29 PM.

Event Timeline

fjricci updated this revision to Diff 55490.Apr 28 2016, 2:29 PM
fjricci retitled this revision from to Split out console and file writing cases in TestCommandScriptImmediateOutput.
fjricci updated this object.
fjricci added a subscriber: lldb-commits.
granata.enrico added inline comments.Apr 28 2016, 8:27 PM
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
29 ↗(On Diff #55619)

Can we raise this a little bit? I worry that going all the way from 60 down to 5 might cause this test to start failing more in load scenarios. Maybe 10 would be a better value?

43 ↗(On Diff #55619)

Feel free to make the file version non pexpect-based if you want

fjricci added inline comments.Apr 29 2016, 9:22 AM
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
29 ↗(On Diff #55619)

I chose 5 because your original console unit test used 5. I changed it to 60 when I added the file aspects. I don't have a problem changing it to 10 though

43 ↗(On Diff #55619)

I ended up finding clayborg's sendline bug-fix, so pexpect should be fine (actually probably preferred)

granata.enrico accepted this revision.Apr 29 2016, 10:11 AM
granata.enrico edited edge metadata.
granata.enrico added inline comments.
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
29 ↗(On Diff #55619)

10 is probably fine - the file version also seems to use 10, so I'd just make them consistent. Other than that LGTM.

This revision is now accepted and ready to land.Apr 29 2016, 10:11 AM
fjricci updated this revision to Diff 55619.Apr 29 2016, 10:14 AM
fjricci edited edge metadata.

Update timeout to 10 seconds for console case

clayborg accepted this revision.Apr 29 2016, 10:57 AM
clayborg edited edge metadata.
This revision was automatically updated to reflect the committed changes.