This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix a gcc warning
AbandonedPublic

Authored by nhaehnle on Apr 27 2016, 4:16 PM.

Details

Summary

.../AMDGPUAsmParser.cpp:1703:12: warning: suggest explicit braces to avoid

                                 ambiguous ‘else’ [-Wparentheses]
if (HwRegCode < 0 || HwRegCode > 63)
   ^

Seems like a good idea even without the warning.

Diff Detail

Event Timeline

nhaehnle updated this revision to Diff 55350.Apr 27 2016, 4:16 PM
nhaehnle retitled this revision from to AMDGPU: Fix a gcc warning.
nhaehnle updated this object.
nhaehnle added a subscriber: llvm-commits.
arsenm edited edge metadata.Apr 27 2016, 4:22 PM

I think the same fix was already committed

nhaehnle abandoned this revision.Apr 27 2016, 4:33 PM

You're right, I hadn't pulled in the last few hours.