Page MenuHomePhabricator

XFail TestLambdas.py on Windows after fixing some of the problems
ClosedPublic

Authored by amccarth on Apr 27 2016, 11:12 AM.

Details

Summary
  1. Fixed semicolon placement in the lambda in the test itself.
  1. Fixed lldbinline tests in general so that we don't attempt tests on platforms that don't use the given type of debug info. (For example, no DWO tests on Windows.) This fixes one of the two failures on Windows. (TestLambdas.py was the only inline test that wasn't XFailed or skipped on Windows.)
  1. Set the error string in IRInterpreter::CanInterpret so that the caller doesn't print (null) instead of an explanation. I don't entirely understand the error, so feel free to suggest a better wording.
  1. XFailed the test on Windows. The interpreter won't evaluate the lambda because the module has multiple function bodies. I don't exactly understand why that's a problem for the interpreter nor why the problem arises only on Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth updated this revision to Diff 55263.Apr 27 2016, 11:12 AM
amccarth retitled this revision from to XFail TestLambdas.py on Windows after fixing some of the problems.
amccarth updated this object.
amccarth added a reviewer: spyffe.
amccarth added a subscriber: lldb-commits.

Zach is hoping to enable tests on our Windows build bot this week, so I'd like to land this in the next day or two if possible. If not, I can just xfail this test on Windows and postpone the other fixes until there's more time for a review.

Thanks.

zturner accepted this revision.May 4 2016, 4:16 PM
zturner edited edge metadata.
This revision is now accepted and ready to land.May 4 2016, 4:16 PM
This revision was automatically updated to reflect the committed changes.