Page MenuHomePhabricator

Use ClangASTContext for compilation units with DW_LANG_RUST
ClosedPublic

Authored by michaelwoerister on Apr 26 2016, 11:16 AM.

Details

Reviewers
jasonmolenda
Summary

Up until recently, LLDB would always use a ClangASTContext, regardless which language was specified in DWARF. While this is not a perfect solution for Rust programs, it at least enabled LLDB to step through them and display variable contents. Until there is a proper Rust language plugin for LLDB, we'd like to keep this behavior so that user can keep using LLDB with the restricted but useful feature set available up until a few months ago.

Diff Detail

Repository
rL LLVM

Event Timeline

michaelwoerister retitled this revision from to Use ClangASTContext for compilation units with DW_LANG_RUST.
michaelwoerister updated this object.
michaelwoerister added a reviewer: jasonmolenda.
michaelwoerister set the repository for this revision to rL LLVM.
michaelwoerister added a subscriber: lldb-commits.
jasonmolenda accepted this revision.Apr 26 2016, 3:08 PM
jasonmolenda edited edge metadata.

Looks good to me. Should I commit this for you, or do you have/want to set up commit access?

This revision is now accepted and ready to land.Apr 26 2016, 3:08 PM

If you could commit that for me, that'd be great! I might be interested in getting commit access when work on a Rust plugin has begun, but for now I'm good without. Thanks again for your help throughout the process.

jasonmolenda closed this revision.Apr 26 2016, 9:57 PM

Committed in r267667.