This is an archive of the discontinued LLVM Phabricator instance.

Differential D19379

[clang-tidy] Fix broken build bot.
ClosedPublic

Authored by etienneb on Apr 21 2016, 11:13 AM.

Download Raw Diff

Details

Reviewers

alexfh
sbenza

Commits

rG7e02656004ce: [clang-tidy] Fix broken build bot.
rCTE267027: [clang-tidy] Fix broken build bot.
rL267027: [clang-tidy] Fix broken build bot.

Summary

There is a build bot that doesn't support 'constexpr'.

FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe   /nologo /TP /DWIN32 /D_WINDOWS   /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4324 -w14062 -we4238 /Zc:inline /Oi /Zc:rvalueCast /MD /O2 /Ob2 -Itools\clang\tools\extra\clang-tidy\misc -ID:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\misc -ID:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\include -Itools\clang\include -Iinclude -ID:\buildslave\clang-x64-ninja-win7\llvm\include    -UNDEBUG  /EHs-c- /GR- /showIncludes -DCLANG_ENABLE_ARCMT -DCLANG_ENABLE_OBJC_REWRITER -DCLANG_ENABLE_STATIC_ANALYZER -DGTEST_HAS_RTTI=0 -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_DEBUG_POINTER_IMPL="" -D_GNU_SOURCE -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS /Fotools\clang\tools\extra\clang-tidy\misc\CMakeFiles\clangTidyMiscModule.dir\SuspiciousStringCompareCheck.cpp.obj /Fdtools\clang\tools\extra\clang-tidy\misc\CMakeFiles\clangTidyMiscModule.dir\ /FS -c D:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\misc\SuspiciousStringCompareCheck.cpp
D:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\misc\SuspiciousStringCompareCheck.cpp(25) : error C2144: syntax error : 'char' should be preceded by ';'
D:\buildslave\clang-x64-ninja-win7\llvm\tools\clang\tools\extra\clang-tidy\misc\SuspiciousStringCompareCheck.cpp(25) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
ninja: build stopped: subcommand failed.
program finished with exit code 1

Diff Detail

Event Timeline

etienneb updated this revision to Diff 54549.Apr 21 2016, 11:13 AM

etienneb retitled this revision from to [clang-tidy] Fix broken build bot..

etienneb updated this object.

etienneb added a reviewer: alexfh.

etienneb added a subscriber: cfe-commits.

sbenza accepted this revision.Apr 21 2016, 11:20 AM

sbenza added a reviewer: sbenza.

This revision is now accepted and ready to land.Apr 21 2016, 11:20 AM

etienneb closed this revision.Apr 21 2016, 11:21 AM

Revision Contents

Path

Size

clang-tidy/

misc/

SuspiciousStringCompareCheck.cpp

88 lines

Diff 54549

clang-tidy/misc/SuspiciousStringCompareCheck.cpp

	Show All 16 Lines
	namespace clang {			namespace clang {
	namespace tidy {			namespace tidy {
	namespace misc {			namespace misc {

	AST_MATCHER(BinaryOperator, isComparisonOperator) {			AST_MATCHER(BinaryOperator, isComparisonOperator) {
	return Node.isComparisonOp();			return Node.isComparisonOp();
	}			}

	constexpr char KnownStringCompareFunctions[] = "__builtin_memcmp;"			static const char KnownStringCompareFunctions[] = "__builtin_memcmp;"
	"__builtin_strcasecmp;"			"__builtin_strcasecmp;"
	"__builtin_strcmp;"			"__builtin_strcmp;"
	"__builtin_strncasecmp;"			"__builtin_strncasecmp;"
	"__builtin_strncmp;"			"__builtin_strncmp;"
	"_mbscmp;"			"_mbscmp;"
	"_mbscmp_l;"			"_mbscmp_l;"
	"_mbsicmp;"			"_mbsicmp;"
	"_mbsicmp_l;"			"_mbsicmp_l;"
	"_mbsnbcmp;"			"_mbsnbcmp;"
	"_mbsnbcmp_l;"			"_mbsnbcmp_l;"
	"_mbsnbicmp;"			"_mbsnbicmp;"
	"_mbsnbicmp_l;"			"_mbsnbicmp_l;"
	"_mbsncmp;"			"_mbsncmp;"
	"_mbsncmp_l;"			"_mbsncmp_l;"
	"_mbsnicmp;"			"_mbsnicmp;"
	"_mbsnicmp_l;"			"_mbsnicmp_l;"
	"_memicmp;"			"_memicmp;"
	"_memicmp_l;"			"_memicmp_l;"
	"_stricmp;"			"_stricmp;"
	"_stricmp_l;"			"_stricmp_l;"
	"_strnicmp;"			"_strnicmp;"
	"_strnicmp_l;"			"_strnicmp_l;"
	"_wcsicmp;"			"_wcsicmp;"
	"_wcsicmp_l;"			"_wcsicmp_l;"
	"_wcsnicmp;"			"_wcsnicmp;"
	"_wcsnicmp_l;"			"_wcsnicmp_l;"
	"lstrcmp;"			"lstrcmp;"
	"lstrcmpi;"			"lstrcmpi;"
	"memcmp;"			"memcmp;"
	"memicmp;"			"memicmp;"
	"strcasecmp;"			"strcasecmp;"
	"strcmp;"			"strcmp;"
	"strcmpi;"			"strcmpi;"
	"stricmp;"			"stricmp;"
	"strncasecmp;"			"strncasecmp;"
	"strncmp;"			"strncmp;"
	"strnicmp;"			"strnicmp;"
	"wcscasecmp;"			"wcscasecmp;"
	"wcscmp;"			"wcscmp;"
	"wcsicmp;"			"wcsicmp;"
	"wcsncmp;"			"wcsncmp;"
	"wcsnicmp;"			"wcsnicmp;"
	"wmemcmp;";			"wmemcmp;";

	static const char StringCompareLikeFunctionsDelimiter[] = ";";			static const char StringCompareLikeFunctionsDelimiter[] = ";";

	static void ParseFunctionNames(StringRef Option,			static void ParseFunctionNames(StringRef Option,
	std::vector<std::string> *Result) {			std::vector<std::string> *Result) {
	SmallVector<StringRef, 4> Functions;			SmallVector<StringRef, 4> Functions;
	Option.split(Functions, StringCompareLikeFunctionsDelimiter);			Option.split(Functions, StringCompareLikeFunctionsDelimiter);
	for (StringRef &Function : Functions) {			for (StringRef &Function : Functions) {
	▲ Show 20 Lines • Show All 145 Lines • Show Last 20 Lines