This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Header cleanup
ClosedPublic

Authored by kevgs on Apr 18 2016, 1:53 AM.

Details

Summary

Removed some unused headers, replaced some headers with forward class declarations.

Found using simple scripts like this one:
clear && ack --cpp -l '#include "llvm/ADT/IndexedMap.h"' | xargs grep -L 'IndexedMap[<]' | xargs grep -n --color=auto 'IndexedMap'

Diff Detail

Event Timeline

kevgs updated this revision to Diff 54040.Apr 18 2016, 1:53 AM
kevgs retitled this revision from to [NFC] Header cleanup.
kevgs updated this object.
kevgs added reviewers: mehdi_amini, chandlerc.
kevgs added a subscriber: llvm-commits.
kevgs added a comment.Apr 18 2016, 1:55 AM

After applying this patch clang file lib/Format/Encoding.h needs to be added a StringRef.h header to fix a build.

mehdi_amini edited edge metadata.Apr 18 2016, 2:07 AM

After this patch, include/llvm/MC/SubtargetFeature.h needs to include <vector> apparently.

kevgs added a comment.Apr 18 2016, 2:17 AM

It looks like diff became a bit outdated while I was compiling llvm locally :)

mehdi_amini accepted this revision.Apr 18 2016, 2:32 AM
mehdi_amini edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 2:32 AM