Page MenuHomePhabricator

[SCEV] Extract out a `isSCEVExprNeverPoison` helper; NFCI
ClosedPublic

Authored by sanjoy on Apr 17 2016, 8:49 PM.

Details

Summary

Also adds a small comment blurb on control flow + no-wrap flags, since
that question came up a few days back on llvm-dev.

Diff Detail

Event Timeline

sanjoy updated this revision to Diff 54025.Apr 17 2016, 8:49 PM
sanjoy retitled this revision from to [SCEV] Extract out a `isSCEVExprNeverPoison` helper; NFCI.
sanjoy updated this object.
sanjoy added reviewers: bjarke.roune, broune.
sanjoy added a subscriber: llvm-commits.
broune accepted this revision.Apr 21 2016, 4:50 PM
broune edited edge metadata.
broune added inline comments.
lib/Analysis/ScalarEvolution.cpp
4782

return false;

4806

I'd prefer adding braces for this multi-line for loop.

4810

This and the next return has different behavior when adding two AddRec's as then the function will always return after considering the first one as the Op but the previous code considered both.

4813

This has different behavior when adding two AddRec's as then the function will always return after considering the first one as the Op but before it considered both.

This revision is now accepted and ready to land.Apr 21 2016, 4:50 PM
This revision was automatically updated to reflect the committed changes.
sanjoy marked 4 inline comments as done.