This is an archive of the discontinued LLVM Phabricator instance.

[mips][ias] Stream macro expansions to output instead of buffering them. NFC.
ClosedPublic

Authored by dsanders on Apr 15 2016, 9:39 AM.

Details

Summary

This will allows us to eliminate some magic numbers from the offset operand of
branch instructions in favour of symbols and makes it possible to avoid
double-filling delay slots when clang is given -save-temps.

parseDirectiveCpRestore() is calling isIntegratedAssemblerRequired() for the
moment since correctly pushing the generation of these instructions into the
ELF target streamer is tricky enough to warrant a separate patch.

Diff Detail

Repository
rL LLVM

Event Timeline

dsanders updated this revision to Diff 53904.Apr 15 2016, 9:39 AM
dsanders retitled this revision from to [mips][ias] Stream macro expansions to output instead of buffering them. NFC..
dsanders updated this object.
dsanders added reviewers: sdardis, vkalintiris.
dsanders added a subscriber: llvm-commits.
vkalintiris accepted this revision.Apr 17 2016, 1:20 PM
vkalintiris edited edge metadata.

LGTM. I have just one question inline.

lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
814–817 ↗(On Diff #53904)

Did you intend to leave this wrapped in preprocessor's if/endif?

This revision is now accepted and ready to land.Apr 17 2016, 1:20 PM

Thanks

lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
814–817 ↗(On Diff #53904)

No, I'll remove it for the commit.

I'll also leave a fixme comment which should clarify why I left the seemingly-redundant if-statement in.

This revision was automatically updated to reflect the committed changes.