This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Fix regclass for the pseudo sgpr spill instructions
AbandonedPublic

Authored by arsenm on Apr 8 2016, 6:40 PM.

Details

Reviewers
tstellarAMD
Summary

The register class for these instructions needs to match the read/write
lane instrutions otherwise we can endup with illegal virtual registrs.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Fix regclass for the pseudo sgpr spill instructions.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm added inline comments.Apr 12 2016, 9:11 AM
lib/Target/AMDGPU/SIInstrInfo.cpp
593

"number sgprs" sounds confusing. How about non-special SGPRs or something like that

687

Missing space aster if

test/CodeGen/AMDGPU/sgpr-spill-regclass.ll
8

Don't need spir_kernel or align 2

466

Thee string attributes can be removed

arsenm added inline comments.Jun 16 2016, 1:56 PM
lib/Target/AMDGPU/SIInstrInfo.cpp
594

Typo srue

arsenm edited edge metadata.Jul 18 2016, 5:21 PM

ping, I just ran into this.

The test can also probably be reduced with inlineasm

test/CodeGen/AMDGPU/sgpr-spill-regclass.ll
10

needs update

arsenm commandeered this revision.Sep 6 2016, 4:07 PM
arsenm edited reviewers, added: tstellarAMD; removed: arsenm.
arsenm abandoned this revision.Sep 6 2016, 4:07 PM

r280584 obsoleted this