This is an archive of the discontinued LLVM Phabricator instance.

[SCEV][LAA] Add tests for SCEV expression transformations performed during LAA
ClosedPublic

Authored by sbaranga on Apr 5 2016, 7:33 AM.

Details

Summary

Add a print method to Predicated Scalar Evolution which prints all interesting
transformations done by PSE.

Loop Access Analysis will now print this as part of the analysis output.
We now use this to check the exact expression transformations that were done
by PSE in LAA.

The additional checking also acts as white-box testing for the getAsAddRec method.

Diff Detail

Event Timeline

sbaranga updated this revision to Diff 52689.Apr 5 2016, 7:33 AM
sbaranga retitled this revision from to [SCEV][LAA] Add tests for SCEV expression transformations performed during LAA.
sbaranga updated this object.
sbaranga added reviewers: anemet, sanjoy.
sbaranga added a subscriber: llvm-commits.
sanjoy accepted this revision.Apr 13 2016, 11:17 PM
sanjoy edited edge metadata.

lgtm with minor stylistic comments

lib/Analysis/ScalarEvolution.cpp
10227

Can you use a range for here?

10230

Same here: why not use a range for loop here?

This revision is now accepted and ready to land.Apr 13 2016, 11:17 PM
sbaranga updated this revision to Diff 53743.Apr 14 2016, 9:13 AM
sbaranga edited edge metadata.

Change both loops to be range-based.

sbaranga closed this revision.Apr 14 2016, 9:14 AM