This is an archive of the discontinued LLVM Phabricator instance.

Allow remote to update individual arch triple components
AbandonedPublic

Authored by fjricci on Mar 30 2016, 2:00 PM.

Details

Summary

If we determine an OS from the executable, but not an environment,
the existing code will not update the target triple to add an
environment provided by the remote.

This manifests if we have an android exe, where we could parse
arm-*-linux from the ELF, but then the remote gives a triple of
arm-*-linux-android. The existing code will not update the
environment in this case, because the OS has not changed.

Diff Detail

Event Timeline

fjricci updated this revision to Diff 52121.Mar 30 2016, 2:00 PM
fjricci retitled this revision from to Allow remote to update individual arch triple components.
fjricci updated this object.
fjricci added reviewers: clayborg, tfiala, tberghammer.
fjricci added subscribers: sas, lldb-commits.
fjricci abandoned this revision.Mar 30 2016, 2:09 PM

Doesn't appear necessary after applying http://reviews.llvm.org/D18620