This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Add TSan __tsan_atomic* functions to tsan_interface.h
ClosedPublic

Authored by kubamracek on Mar 29 2016, 3:01 AM.

Details

Summary

To avoid using the public header (tsan_interface_atomic.h), which has different data types, let's add all the __tsan_atomic* functions to tsan_interface.h. This is needed for http://reviews.llvm.org/D18500.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 51887.Mar 29 2016, 3:01 AM
kubamracek retitled this revision from to [tsan] Add TSan __tsan_atomic* functions to tsan_interface.h.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, kcc, glider, samsonov.
dvyukov accepted this revision.Apr 4 2016, 12:47 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2016, 12:47 AM
kubamracek updated this revision to Diff 52538.Apr 4 2016, 3:23 AM
kubamracek edited edge metadata.

I needed to add #ifndef SANITIZER_GO in order to make GotsanRuntimeCheck pass.

kubamracek requested a review of this revision.Apr 4 2016, 3:23 AM
kubamracek edited edge metadata.
dvyukov accepted this revision.Apr 4 2016, 3:51 AM
dvyukov edited edge metadata.

if check-tsan passes then LGTM

This revision is now accepted and ready to land.Apr 4 2016, 3:51 AM
This revision was automatically updated to reflect the committed changes.