This is an archive of the discontinued LLVM Phabricator instance.

Differential D18520

Initialize ProcessWindowsLive when building LLDB with MinGW
Needs ReviewPublic

Authored by eran.ifrah on Mar 28 2016, 12:12 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Initialize ProcessWindowsLive when building LLDB with MinGW

Diff Detail

Event Timeline

eran.ifrah updated this revision to Diff 51819.Mar 28 2016, 12:12 PM
eran.ifrah retitled this revision from to Initialize ProcessWindowsLive when building LLDB with MinGW.
eran.ifrah updated this object.
eran.ifrah added a reviewer: zturner.
eran.ifrah added a subscriber: lldb-commits.
zturner added inline comments.Mar 28 2016, 12:44 PM
source/API/SystemInitializerFull.cpp
90

Just use LLVM_ON_WIN32 for both of these places, otherwise looks good.

eran.ifrah added inline comments.Mar 28 2016, 12:48 PM
source/API/SystemInitializerFull.cpp
90

I tried using LLVM_ON_WIN32 but it does not defined with MinGW ( to confirm this, I placed an #error directive to ensure that it does not reach there, so I ended up using __MINGW32__ which is defined for both MinGW32 and 64

zturner added inline comments.Mar 28 2016, 12:51 PM
source/API/SystemInitializerFull.cpp
90

Strange, I looked at the CMake code in HandleLLVMOptions.cmake and it says this:

if(WIN32)
  set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
  if(CYGWIN)
    set(LLVM_ON_WIN32 0)
    set(LLVM_ON_UNIX 1)
  else(CYGWIN)
    set(LLVM_ON_WIN32 1)
    set(LLVM_ON_UNIX 0)
  endif(CYGWIN)

So it LLVM_ON_WIN32 should be false only if you are building from inside of Cygwin. Is that the case for you?

What if you use #if defined(_WIN32)?

zturner resigned from this revision.Jun 2 2016, 8:36 PM
zturner removed a reviewer: zturner.

Revision Contents

PathSize
source/
API/
4 lines

Diff 51819

source/API/SystemInitializerFull.cpp

Context not available.
#include "Plugins/Process/FreeBSD/ProcessFreeBSD.h" #include "Plugins/Process/FreeBSD/ProcessFreeBSD.h"
#endif #endif
#if defined(_MSC_VER) #if defined(_MSC_VER) || defined(__MINGW32__)
zturnerUnsubmitted
Not Done
ReplyInline Actions

Just use LLVM_ON_WIN32 for both of these places, otherwise looks good.

zturner: Just use `LLVM_ON_WIN32` for both of these places, otherwise looks good.
eran.ifrahAuthorUnsubmitted
Not Done
ReplyInline Actions

I tried using LLVM_ON_WIN32 but it does not defined with MinGW ( to confirm this, I placed an #error directive to ensure that it does not reach there, so I ended up using __MINGW32__ which is defined for both MinGW32 and 64

eran.ifrah: I tried using `LLVM_ON_WIN32` but it does not defined with MinGW ( to confirm this, I placed…
zturnerUnsubmitted
Not Done
ReplyInline Actions

Strange, I looked at the CMake code in HandleLLVMOptions.cmake and it says this:

if(WIN32)
  set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
  if(CYGWIN)
    set(LLVM_ON_WIN32 0)
    set(LLVM_ON_UNIX 1)
  else(CYGWIN)
    set(LLVM_ON_WIN32 1)
    set(LLVM_ON_UNIX 0)
  endif(CYGWIN)

So it LLVM_ON_WIN32 should be false only if you are building from inside of Cygwin. Is that the case for you?

What if you use #if defined(_WIN32)?

zturner: Strange, I looked at the CMake code in `HandleLLVMOptions.cmake` and it says this: ``` if…
#include "lldb/Host/windows/windows.h" #include "lldb/Host/windows/windows.h"
#include "Plugins/Process/Windows/Live/ProcessWindowsLive.h" #include "Plugins/Process/Windows/Live/ProcessWindowsLive.h"
#include "Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h" #include "Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h"
Context not available.
ObjCLanguage::Initialize(); ObjCLanguage::Initialize();
ObjCPlusPlusLanguage::Initialize(); ObjCPlusPlusLanguage::Initialize();
#if defined(_MSC_VER) #if defined(_MSC_VER) || defined(__MINGW32__)
ProcessWindowsLive::Initialize(); ProcessWindowsLive::Initialize();
#endif #endif
#if defined(__FreeBSD__) #if defined(__FreeBSD__)
Context not available.