This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add test for generic builtin behavior
ClosedPublic

Authored by arsenm on Mar 25 2016, 6:25 AM.

Details

Reviewers
tstellarAMD
Summary

This is the same as the default implementation, but
add a comment and make sure the behavior is tested.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 51632.Mar 25 2016, 6:25 AM
arsenm retitled this revision from to AMDGPU: Add test for generic builtin behavior.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
lib/Basic/Targets.cpp
1854–1857

Why do we need to add this if it's the same as the default?

arsenm added inline comments.Apr 12 2016, 2:18 PM
lib/Basic/Targets.cpp
1854–1857

Don't really, other than it adds a comment. I can keep just the test

tstellarAMD accepted this revision.Apr 13 2016, 5:58 AM
tstellarAMD edited edge metadata.
tstellarAMD added inline comments.
lib/Basic/Targets.cpp
1854–1857

Ok, sounds good. LGTM.

This revision is now accepted and ready to land.Apr 13 2016, 5:58 AM
arsenm closed this revision.Apr 14 2016, 3:40 PM

r266383