This is in preparation for tail duplication during block placement. See D18226.
This needs to be a utility class for 2 reasons. No passes may run after block
placement, and also, tail-duplication affects subsequent layout decisions, so
it must be interleaved with placement, and can't be separated out into its own
pass. The original pass is still useful, and now runs by delegating to the
utility class.
Details
Details
- Reviewers
echristo
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Please clang format :)
One inline comment as well.
Question: Is your next patch going to call this from another pass? If so, I think it makes sense to pull it out from TailDuplication.cpp (yes, leaving that as one of the most boring passes in existence). If not, then I think it's fine as is.
Thanks!
-eric
include/llvm/CodeGen/TailDuplicator.h | ||
---|---|---|
2 | Ahem. |
Comment Actions
clang-format and split into 2 separate files as requested.
Sorry about the delay, was attempting to get performance numbers for the following change.
Comment Actions
One inline comment, otherwise I'm assuming this is just copying from one location to another and running clang-format on the resulting files :)
-eric
include/llvm/CodeGen/TailDuplicator.h | ||
---|---|---|
3 | Still missed the comment here :) |
Ahem.