This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Fix check-tsan build by using CHECK_NE.
ClosedPublic

Authored by yabinc on Mar 22 2016, 10:55 AM.

Reviewers

Commits

yabinc retitled this revision from to [tsan] Fix check-tsan build by using CHECK_NE..

yabinc updated this object.

yabinc added a subscriber: srhines.

srhines added a reviewer: srhines.

This revision is now accepted and ready to land.Mar 22 2016, 10:58 AM

LGTM I guess

Path

Size

lib/

tsan/

rtl/

2 lines

Show First 20 Lines • Show All 296 Lines • ▼ Show 20 Lines	if (kCppMode) {
// from 128M to 36G on 39-bit aarch64. As it is almost impossible to cover		// from 128M to 36G on 39-bit aarch64. As it is almost impossible to cover
// this big range, we should disable randomized virtual space on aarch64.		// this big range, we should disable randomized virtual space on aarch64.
#if defined(__aarch64__)		#if defined(__aarch64__)
int old_personality = personality(0xffffffff);		int old_personality = personality(0xffffffff);
if (old_personality != -1 && (old_personality & ADDR_NO_RANDOMIZE) == 0) {		if (old_personality != -1 && (old_personality & ADDR_NO_RANDOMIZE) == 0) {
Report("WARNING: Program is run with randomized virtual address space,"		Report("WARNING: Program is run with randomized virtual address space,"
" which wouldn't work with ThreadSanitizer.\n");		" which wouldn't work with ThreadSanitizer.\n");
Report("Re-execing with fixed virtual address space.\n");		Report("Re-execing with fixed virtual address space.\n");
CHECK(personality(old_personality \| ADDR_NO_RANDOMIZE) != -1);		CHECK_NE(-1, personality(old_personality \| ADDR_NO_RANDOMIZE));
reexec = true;		reexec = true;
}		}
#endif		#endif
if (reexec)		if (reexec)
ReExec();		ReExec();
}		}

#ifndef SANITIZER_GO		#ifndef SANITIZER_GO
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines