This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] Disable cxa_thread_atexit_test if unavailable
ClosedPublic

Authored by Hahnfeld on Mar 16 2016, 2:24 AM.

Diff Detail

Event Timeline

Hahnfeld updated this revision to Diff 50805.Mar 16 2016, 2:24 AM
Hahnfeld retitled this revision from to [libcxxabi] Disable cxa_thread_atexit_test if unavailable.
Hahnfeld updated this object.
Hahnfeld added reviewers: EricWF, danalbert.
Hahnfeld added a subscriber: cfe-commits.
EricWF accepted this revision.Mar 16 2016, 11:58 AM
EricWF edited edge metadata.

LGTM after the inline question is addressed.

test/libcxxabi/test/config.py
38

I would rather default this value to True. Would this break in your case?

This revision is now accepted and ready to land.Mar 16 2016, 11:58 AM
Hahnfeld added inline comments.Mar 16 2016, 12:24 PM
test/libcxxabi/test/config.py
38

Not when running all tests from make or directly with llvm-lit and relative directories. But it would break when starting llvm-lit with an absolute path because it then takes the default configuration. I won't ever do that though because I know that this test doesn't work with my version of glibc ;-)

Will change and commit tomorrow, thanks!

This revision was automatically updated to reflect the committed changes.