This is an archive of the discontinued LLVM Phabricator instance.

Differential D18063

AMDGPU/SI: Don't allow vcc outputs for SMRD instructions
AbandonedPublic

Authored by • tstellarAMD on Mar 10 2016, 2:17 PM.

Details

Reviewers
arsenm
Summary

This doesn't seem to work when we allocate more than 104 SGPRs,
and this is the only time we would ever use vcc for SMRD instructions.

Diff Detail

Event Timeline

• tstellarAMD updated this revision to Diff 50354.Mar 10 2016, 2:17 PM
• tstellarAMD retitled this revision from to AMDGPU/SI: Don't allow vcc outputs for SMRD instructions.
• tstellarAMD updated this object.
• tstellarAMD added a reviewer: arsenm.
• tstellarAMD added a subscriber: llvm-commits.
Herald added a subscriber: arsenm. · View Herald TranscriptMar 10 2016, 2:17 PM
arsenm accepted this revision.Mar 10 2016, 2:34 PM
arsenm edited edge metadata.

LGTM. Needs a comment about why

This revision is now accepted and ready to land.Mar 10 2016, 2:34 PM
• tstellarAMD abandoned this revision.Apr 12 2016, 5:19 PM

The breaks the assembler/disassembler, we need to take a different approach.

Revision Contents

PathSize
lib/
Target/
AMDGPU/
2 lines

Diff 50354

lib/Target/AMDGPU/SIInstructions.td

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// SMRD Instructions // SMRD Instructions
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// We are using the SGPR_32 and not the SReg_32 register class for 32-bit // We are using the SGPR_32 and not the SReg_32 register class for 32-bit
// SMRD instructions, because the SGPR_32 register class does not include M0 // SMRD instructions, because the SGPR_32 register class does not include M0
// and writing to M0 from an SMRD instruction will hang the GPU. // and writing to M0 from an SMRD instruction will hang the GPU.
defm S_LOAD_DWORD : SMRD_Helper <smrd<0x00>, "s_load_dword", SReg_64, SGPR_32>; defm S_LOAD_DWORD : SMRD_Helper <smrd<0x00>, "s_load_dword", SReg_64, SGPR_32>;
defm S_LOAD_DWORDX2 : SMRD_Helper <smrd<0x01>, "s_load_dwordx2", SReg_64, SReg_64>; defm S_LOAD_DWORDX2 : SMRD_Helper <smrd<0x01>, "s_load_dwordx2", SReg_64, SGPR_64>;
defm S_LOAD_DWORDX4 : SMRD_Helper <smrd<0x02>, "s_load_dwordx4", SReg_64, SReg_128>; defm S_LOAD_DWORDX4 : SMRD_Helper <smrd<0x02>, "s_load_dwordx4", SReg_64, SReg_128>;
defm S_LOAD_DWORDX8 : SMRD_Helper <smrd<0x03>, "s_load_dwordx8", SReg_64, SReg_256>; defm S_LOAD_DWORDX8 : SMRD_Helper <smrd<0x03>, "s_load_dwordx8", SReg_64, SReg_256>;
defm S_LOAD_DWORDX16 : SMRD_Helper <smrd<0x04>, "s_load_dwordx16", SReg_64, SReg_512>; defm S_LOAD_DWORDX16 : SMRD_Helper <smrd<0x04>, "s_load_dwordx16", SReg_64, SReg_512>;
defm S_BUFFER_LOAD_DWORD : SMRD_Helper < defm S_BUFFER_LOAD_DWORD : SMRD_Helper <
smrd<0x08>, "s_buffer_load_dword", SReg_128, SGPR_32 smrd<0x08>, "s_buffer_load_dword", SReg_128, SGPR_32
>; >;
▲ Show 20 Lines • Show All 3,169 Lines • Show Last 20 Lines