This is an archive of the discontinued LLVM Phabricator instance.

[MIPS] Make Static a default relocation model for MIPS codegen
ClosedPublic

Authored by petarj on Mar 9 2016, 8:31 AM.

Details

Summary

This change follows up defaults for GCC and Clang, so LLVM does not differ
from them. While number of the test files are touched with this change, they
all keep the old (expected) behaviour with the explicit option:
"-relocation-model=pic"
The tests that have not been touched are insensitive to relocation model.

Diff Detail

Repository
rL LLVM

Event Timeline

petarj updated this revision to Diff 50146.Mar 9 2016, 8:31 AM
petarj retitled this revision from to [MIPS] Make Static a default relocation model for MIPS codegen.
petarj updated this object.
petarj set the repository for this revision to rL LLVM.
petarj added a subscriber: llvm-commits.
dsanders accepted this revision.Apr 8 2016, 1:35 AM
dsanders edited edge metadata.

LGTM.

I had thought that this introduced strange defaults for Linux but it turned that our toolchains are a bit inconsistent about the behaviour of -fpic/-fno-pic. Our 'mti' and 'img' toolchains work as you'd expect but Debian's acts like -fpic when given -fno-pic.

This revision is now accepted and ready to land.Apr 8 2016, 1:35 AM
This revision was automatically updated to reflect the committed changes.