This is an archive of the discontinued LLVM Phabricator instance.

[CLANG][AVX512][BUILTIN] Adding new feature flag header files and new BUILTIN vpermi2varq{i|t}{128|256|512}{mask|maskz}
ClosedPublic

Authored by m_zuckerman on Mar 6 2016, 6:13 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

m_zuckerman updated this revision to Diff 49912.Mar 6 2016, 6:13 AM
m_zuckerman retitled this revision from to [CLANG][AVX512][BUILTIN] Adding new feature flag headed files and new BUILTIN vpermi2varq{i|t}{128|256|512}{mask|maskz} .
m_zuckerman updated this object.
m_zuckerman added reviewers: AsafBadouh, delena, igorb.
m_zuckerman added a subscriber: llvm-commits.
delena accepted this revision.Mar 6 2016, 6:52 AM
delena edited edge metadata.

minor comment, LGTM

lib/Headers/avx512vbmivlintrin.h
34 ↗(On Diff #49912)

Do not put more than one empty line. It is LLVM style requirement.

This revision is now accepted and ready to land.Mar 6 2016, 6:52 AM
This revision was automatically updated to reflect the committed changes.

Why is are the headers (license text) in this commit different from all the usual one?

(Also I can't make sense of the commit title "Adding new feature flag headed file", but I have to say that English is not my native language)

m_zuckerman retitled this revision from [CLANG][AVX512][BUILTIN] Adding new feature flag headed files and new BUILTIN vpermi2varq{i|t}{128|256|512}{mask|maskz} to [CLANG][AVX512][BUILTIN] Adding new feature flag header files and new BUILTIN vpermi2varq{i|t}{128|256|512}{mask|maskz} .Mar 7 2016, 11:40 PM
m_zuckerman edited edge metadata.