This is an archive of the discontinued LLVM Phabricator instance.

Fix DivRem DAGCombine not to assume div/rem type is simple
ClosedPublic

Authored by mkuper on Mar 3 2016, 11:41 PM.

Details

Summary

The divrem combine assumes the type of the div/rem is simple, which isn't necessarily true.
I'm guessing that it worked fine until r250825, since it probably only saw legal types, but now breaks when it runs as a pre-type-legalization combine.

This fixes PR26835.

Diff Detail

Repository
rL LLVM

Event Timeline

mkuper updated this revision to Diff 49800.Mar 3 2016, 11:41 PM
mkuper retitled this revision from to Fix DivRem DAGCombine not to assume div/rem type is simple.
mkuper updated this object.
mkuper added reviewers: tyomitch, rengolin.
mkuper added a subscriber: llvm-commits.
tyomitch accepted this revision.Mar 4 2016, 12:25 AM
tyomitch edited edge metadata.
This revision is now accepted and ready to land.Mar 4 2016, 12:25 AM
This revision was automatically updated to reflect the committed changes.