This is an archive of the discontinued LLVM Phabricator instance.

Differential D17376

dump_ast_matchers.py: fix replacement regexps
ClosedPublic

Authored by a.sidorin on Feb 18 2016, 6:25 AM.

Details

Reviewers
klimek
aaron.ballman
Commits
rG75118f5d3d46: [analyzer] dump_ast_matchers.py: fix replacement regexps
rC261219: [analyzer] dump_ast_matchers.py: fix replacement regexps
rL261219: [analyzer] dump_ast_matchers.py: fix replacement regexps
Summary

Using re.sub() to replace a sample with '%'s looks strange and causes a format string error if a matcher description contains "%s". This patch resolves this issue.

Diff Detail

Repository
rL LLVM

Event Timeline

a.sidorin updated this revision to Diff 48306.Feb 18 2016, 6:25 AM
a.sidorin retitled this revision from to dump_ast_matchers.py: fix replacement regexps.
a.sidorin updated this object.
a.sidorin added reviewers: klimek, aaron.ballman.
a.sidorin set the repository for this revision to rL LLVM.
a.sidorin added a subscriber: cfe-commits.
klimek accepted this revision.Feb 18 2016, 6:35 AM
klimek edited edge metadata.

lg

This revision is now accepted and ready to land.Feb 18 2016, 6:35 AM
Closed by commit rL261219: [analyzer] dump_ast_matchers.py: fix replacement regexps (authored by ygribov). · Explain WhyFeb 18 2016, 7:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
docs/
tools/
6 lines

Diff 48316

cfe/trunk/docs/tools/dump_ast_matchers.py

Show First 20 Lines • Show All 357 Lines • ▼ Show 20 Lines if ((not line.strip()) or
allowed_types = [] allowed_types = []
node_matcher_table = sort_table('DECL', node_matchers) node_matcher_table = sort_table('DECL', node_matchers)
narrowing_matcher_table = sort_table('NARROWING', narrowing_matchers) narrowing_matcher_table = sort_table('NARROWING', narrowing_matchers)
traversal_matcher_table = sort_table('TRAVERSAL', traversal_matchers) traversal_matcher_table = sort_table('TRAVERSAL', traversal_matchers)
reference = open('../LibASTMatchersReference.html').read() reference = open('../LibASTMatchersReference.html').read()
reference = re.sub(r'<!-- START_DECL_MATCHERS.*END_DECL_MATCHERS -->', reference = re.sub(r'<!-- START_DECL_MATCHERS.*END_DECL_MATCHERS -->',
'%s', reference, flags=re.S) % node_matcher_table node_matcher_table, reference, flags=re.S)
reference = re.sub(r'<!-- START_NARROWING_MATCHERS.*END_NARROWING_MATCHERS -->', reference = re.sub(r'<!-- START_NARROWING_MATCHERS.*END_NARROWING_MATCHERS -->',
'%s', reference, flags=re.S) % narrowing_matcher_table narrowing_matcher_table, reference, flags=re.S)
reference = re.sub(r'<!-- START_TRAVERSAL_MATCHERS.*END_TRAVERSAL_MATCHERS -->', reference = re.sub(r'<!-- START_TRAVERSAL_MATCHERS.*END_TRAVERSAL_MATCHERS -->',
'%s', reference, flags=re.S) % traversal_matcher_table traversal_matcher_table, reference, flags=re.S)
with open('../LibASTMatchersReference.html', 'wb') as output: with open('../LibASTMatchersReference.html', 'wb') as output:
output.write(reference) output.write(reference)