request for approval to commit: llvm-c: Fix name of LLVMAddDemoteRegisterToMemoryPass function.

[wanders]

Summary

It has the name reversed (LLVMAddDemoteMemoryToRegisterPass).

The ocaml bindings still have it reversed: llvm_add_memory_to_register_demotion.

[echristo]

LGTM. Be careful when you submit as you might break things.

[echristo]

Were you ever going to commit this?

[• rafael]

Hi, what is this pass being used for?

I noticed that the utility functions are still used for sjlj lowering, but otherwise it looked dead in trunk.

bindings/ocaml/transforms/scalar/scalar_opts_ocaml.c

 /* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
 CAMLprim value llvm_add_memory_to_register_promotion(LLVMPassManagerRef PM) {
   LLVMAddPromoteMemoryToRegisterPass(PM);
   return Val_unit;
 }
 
 /* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
 CAMLprim value llvm_add_memory_to_register_demotion(LLVMPassManagerRef PM) {
-  LLVMAddDemoteMemoryToRegisterPass(PM);
+  LLVMAddDemoteRegisterToMemoryPass(PM);
   return Val_unit;
 }
 
 /* [<Llvm.PassManager.any] Llvm.PassManager.t -> unit */
 CAMLprim value llvm_add_reassociation(LLVMPassManagerRef PM) {
   LLVMAddReassociatePass(PM);
   return Val_unit;
 }

include/llvm-c/Transforms/Scalar.h

 void LLVMAddSimplifyLibCallsPass(LLVMPassManagerRef PM);
 
 /** See llvm::createTailCallEliminationPass function. */
 void LLVMAddTailCallEliminationPass(LLVMPassManagerRef PM);
 
 /** See llvm::createConstantPropagationPass function. */
 void LLVMAddConstantPropagationPass(LLVMPassManagerRef PM);
 
-/** See llvm::demotePromoteMemoryToRegisterPass function. */
-void LLVMAddDemoteMemoryToRegisterPass(LLVMPassManagerRef PM);
+/** See llvm::createDemoteRegisterToMemoryPass function. */
+void LLVMAddDemoteRegisterToMemoryPass(LLVMPassManagerRef PM);
 
 /** See llvm::createVerifierPass function. */
 void LLVMAddVerifierPass(LLVMPassManagerRef PM);
 
 /** See llvm::createCorrelatedValuePropagationPass function */
 void LLVMAddCorrelatedValuePropagationPass(LLVMPassManagerRef PM);
 
 /** See llvm::createEarlyCSEPass function */

lib/Transforms/Scalar/Scalar.cpp

 void LLVMAddTailCallEliminationPass(LLVMPassManagerRef PM) {
   unwrap(PM)->add(createTailCallEliminationPass());
 }
 
 void LLVMAddConstantPropagationPass(LLVMPassManagerRef PM) {
   unwrap(PM)->add(createConstantPropagationPass());
 }
 
-void LLVMAddDemoteMemoryToRegisterPass(LLVMPassManagerRef PM) {
+void LLVMAddDemoteRegisterToMemoryPass(LLVMPassManagerRef PM) {
   unwrap(PM)->add(createDemoteRegisterToMemoryPass());
 }
 
 void LLVMAddVerifierPass(LLVMPassManagerRef PM) {
   unwrap(PM)->add(createVerifierPass());
 }
 
 void LLVMAddCorrelatedValuePropagationPass(LLVMPassManagerRef PM) {