This is an archive of the discontinued LLVM Phabricator instance.

Differential D17112

AMDGPU: Fix not handling new workitem intrinsics in DivergenceAnalysis
ClosedPublic

Authored by arsenm on Feb 10 2016, 4:40 PM.

Details

Reviewers
• tstellarAMD

Diff Detail

Event Timeline

arsenm updated this revision to Diff 47559.Feb 10 2016, 4:40 PM
arsenm retitled this revision from to AMDGPU: Fix not handling new workitem intrinsics in DivergenceAnalysis.
arsenm updated this object.
arsenm added a reviewer: • tstellarAMD.
arsenm added a subscriber: llvm-commits.
Herald added a subscriber: arsenm. · View Herald TranscriptFeb 10 2016, 4:40 PM
• tstellarAMD accepted this revision.Feb 10 2016, 6:35 PM
• tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 10 2016, 6:35 PM
arsenm closed this revision.Feb 10 2016, 9:37 PM

r260491

Revision Contents

PathSize
lib/
Target/
AMDGPU/
3 lines
test/
Analysis/
DivergenceAnalysis/
AMDGPU/
45 lines

Diff 47559

lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Linesstatic bool isIntrinsicSourceOfDivergence(const TargetIntrinsicInfo *TII,
switch (I->getIntrinsicID()) { switch (I->getIntrinsicID()) {
default: default:
return false; return false;
case Intrinsic::not_intrinsic: case Intrinsic::not_intrinsic:
// This means we have an intrinsic that isn't defined in // This means we have an intrinsic that isn't defined in
// IntrinsicsAMDGPU.td // IntrinsicsAMDGPU.td
break; break;
case Intrinsic::amdgcn_workitem_id_x:
case Intrinsic::amdgcn_workitem_id_y:
case Intrinsic::amdgcn_workitem_id_z:
case Intrinsic::amdgcn_interp_p1: case Intrinsic::amdgcn_interp_p1:
case Intrinsic::amdgcn_interp_p2: case Intrinsic::amdgcn_interp_p2:
case Intrinsic::amdgcn_mbcnt_hi: case Intrinsic::amdgcn_mbcnt_hi:
case Intrinsic::amdgcn_mbcnt_lo: case Intrinsic::amdgcn_mbcnt_lo:
case Intrinsic::r600_read_tidig_x: case Intrinsic::r600_read_tidig_x:
case Intrinsic::r600_read_tidig_y: case Intrinsic::r600_read_tidig_y:
case Intrinsic::r600_read_tidig_z: case Intrinsic::r600_read_tidig_z:
return true; return true;
▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines

test/Analysis/DivergenceAnalysis/AMDGPU/workitem-intrinsics.ll

  • This file was added.
; RUN: opt -mtriple amdgcn-unknown-amdhsa -analyze -divergence %s | FileCheck %s
declare i32 @llvm.amdgcn.workitem.id.x() #0
declare i32 @llvm.amdgcn.workitem.id.y() #0
declare i32 @llvm.amdgcn.workitem.id.z() #0
declare i32 @llvm.amdgcn.mbcnt.lo(i32, i32) #0
declare i32 @llvm.amdgcn.mbcnt.hi(i32, i32) #0
; CHECK: DIVERGENT: %id.x = call i32 @llvm.amdgcn.workitem.id.x()
define void @workitem_id_x() #1 {
%id.x = call i32 @llvm.amdgcn.workitem.id.x()
store volatile i32 %id.x, i32 addrspace(1)* undef
ret void
}
; CHECK: DIVERGENT: %id.y = call i32 @llvm.amdgcn.workitem.id.y()
define void @workitem_id_y() #1 {
%id.y = call i32 @llvm.amdgcn.workitem.id.y()
store volatile i32 %id.y, i32 addrspace(1)* undef
ret void
}
; CHECK: DIVERGENT: %id.z = call i32 @llvm.amdgcn.workitem.id.z()
define void @workitem_id_z() #1 {
%id.z = call i32 @llvm.amdgcn.workitem.id.z()
store volatile i32 %id.z, i32 addrspace(1)* undef
ret void
}
; CHECK: DIVERGENT: %mbcnt.lo = call i32 @llvm.amdgcn.mbcnt.lo(i32 0, i32 0)
define void @mbcnt_lo() #1 {
%mbcnt.lo = call i32 @llvm.amdgcn.mbcnt.lo(i32 0, i32 0)
store volatile i32 %mbcnt.lo, i32 addrspace(1)* undef
ret void
}
; CHECK: DIVERGENT: %mbcnt.hi = call i32 @llvm.amdgcn.mbcnt.hi(i32 0, i32 0)
define void @mbcnt_hi() #1 {
%mbcnt.hi = call i32 @llvm.amdgcn.mbcnt.hi(i32 0, i32 0)
store volatile i32 %mbcnt.hi, i32 addrspace(1)* undef
ret void
}
attributes #0 = { nounwind readnone }
attributes #1 = { nounwind }