AMDGPU/SI: When splitting SMRD instructions, add its users to VALU worklist

[• tstellarAMD]

Summary

When we split SMRD instructions into two MUBUFs we were adding the users
of the newly created MUBUFs to the VALU worklist. However, the only
users these instructions had was the REG_SEQUENCE that was inserted
by splitSMRD when the original SMRD instruction was split.

We need to make sure to add the users of the original SMRD to the VALU
worklist before it is split.

I have a test case, but it requires one other bug fix, so it will be
added in a later commt.

[arsenm]

LGTM.

I should finish my patch to create a global worklist to stop hitting this problem again

llvm/trunk/lib/Target/AMDGPU/SIInstrInfo.cpp

case 16: {
       MI->eraseFromParent();
 
       legalizeOperands(NewInst);
       addUsersToMoveToVALUWorklist(NewDstReg, MRI, Worklist);
       break;
     }
     case 32: {
       MachineInstr *Lo, *Hi;
+      addUsersToMoveToVALUWorklist(MI->getOperand(0).getReg(), MRI, Worklist);
       splitSMRD(MI, &AMDGPU::SReg_128RegClass, AMDGPU::S_LOAD_DWORDX4_IMM,
                 AMDGPU::S_LOAD_DWORDX4_SGPR, Lo, Hi);
       MI->eraseFromParent();
       moveSMRDToVALU(Lo, MRI, Worklist);
       moveSMRDToVALU(Hi, MRI, Worklist);
       break;
     }
 
     case 64: {
       MachineInstr *Lo, *Hi;
+      addUsersToMoveToVALUWorklist(MI->getOperand(0).getReg(), MRI, Worklist);
       splitSMRD(MI, &AMDGPU::SReg_256RegClass, AMDGPU::S_LOAD_DWORDX8_IMM,
                 AMDGPU::S_LOAD_DWORDX8_SGPR, Lo, Hi);
       MI->eraseFromParent();
       moveSMRDToVALU(Lo, MRI, Worklist);
       moveSMRDToVALU(Hi, MRI, Worklist);
       break;
     }
   }