This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj][ELF] Show MIPS GOT content when there is another zero-sized section at the same address
ClosedPublic

Authored by atanasyan on Feb 7 2016, 9:57 AM.

Details

Summary

It is possible to have .got section and one or more zero-sized section at the same address. This patch first checks that GOT (or GOT PLT) section should have non-zero size using corresponding dynamic tags. Then it looks up not empty section at the specified address.

Diff Detail

Repository
rL LLVM

Event Timeline

atanasyan updated this revision to Diff 47135.Feb 7 2016, 9:57 AM
atanasyan retitled this revision from to [llvm-readobj][ELF] Show MIPS GOT content when there is another zero-sized section at the same address.
atanasyan updated this object.
atanasyan added a reviewer: rafael.
atanasyan set the repository for this revision to rL LLVM.
atanasyan added a subscriber: llvm-commits.
rafael added inline comments.Feb 8 2016, 1:55 PM
tools/llvm-readobj/ELFDumper.cpp
1889

This is a corrupted file and should be an error, no?

1966

This is also a corrupted file, no?

atanasyan updated this revision to Diff 47309.Feb 9 2016, 5:57 AM
  • Use report_fatal_error to show errors and exit with non-zero code
rafael accepted this revision.Feb 9 2016, 8:54 AM
rafael edited edge metadata.

lgtm

This revision is now accepted and ready to land.Feb 9 2016, 8:54 AM
This revision was automatically updated to reflect the committed changes.