This is an archive of the discontinued LLVM Phabricator instance.

[CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.
ClosedPublic

Authored by tra on Feb 5 2016, 1:34 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

tra updated this revision to Diff 47040.Feb 5 2016, 1:34 PM
tra retitled this revision from to [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers..
tra updated this object.
tra added reviewers: jingyue, jlebar.
tra added a subscriber: cfe-commits.
jlebar accepted this revision.Feb 5 2016, 1:37 PM
jlebar edited edge metadata.

Is it worth having a test, if only for one or two functions?

This revision is now accepted and ready to land.Feb 5 2016, 1:37 PM
tra added a comment.Feb 5 2016, 2:07 PM

I'm not sure what we could test here without CUDA headers.
I've tested out-of-tree by compiling thrust unit tests and the test case in PR.

jlebar added a comment.Feb 5 2016, 2:09 PM

Oh right, CUDA headers.

We really need to get a buildbot and/or tests in test-suite set up.

This revision was automatically updated to reflect the committed changes.