This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Account for LDS alignment
ClosedPublic

Authored by arsenm on Feb 4 2016, 1:16 PM.

Details

Reviewers
tstellarAMD
Summary

The current situation isn't great, because the amount of padding
requires is determined by the inverse order of the first encountered
use. We should eventually somehow sort these to minimize wasted space.

Another problem is the alignment of kernel arguments isn't
respected. The group_segment_alignment is always emitted as
the default 16, and typed arguments with higher alignments
or an explicitly set alignment are also ignored.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 46953.Feb 4 2016, 1:16 PM
arsenm retitled this revision from to AMDGPU: Account for LDS alignment.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Feb 4 2016, 1:32 PM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 4 2016, 1:32 PM
arsenm closed this revision.Feb 5 2016, 11:52 AM

r259912