This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix breaking IR on instructions with multiple pointer operands
ClosedPublic

Authored by arsenm on Feb 1 2016, 12:21 PM.

Details

Reviewers
tstellarAMD
Summary

The promote alloca pass would attempt to promote an alloca with
a select, icmp, or phi user, even though the other operand was
from a non-promotable source, producing a select on two different
pointer types.

Only do this if we know that both operands derive from the same
alloca. In the future we should be able to relax this to an alloca
which will also be promoted.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 46565.Feb 1 2016, 12:21 PM
arsenm retitled this revision from to AMDGPU: Fix breaking IR on instructions with multiple pointer operands.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Feb 2 2016, 8:44 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 2 2016, 8:44 AM
arsenm closed this revision.May 11 2016, 7:32 PM

r269265