This is an archive of the discontinued LLVM Phabricator instance.

Add a function to get the largest address space pointer size
AbandonedPublic

Authored by arsenm on Sep 12 2013, 4:08 PM.

Details

Reviewers
None
Summary

Some users of DataLayout::getPointerSize don't use it in an exact way, and aren't really using it for the pointer size. For example MemCpyOptimizer uses it as a guess for the maximum GPR width.

Diff Detail

Event Timeline

I don't have much to say about the method itself, but usually patches that introduce a new function/method have diffs to actually use that method as well. Does 'getMaxPointerSize' have any specific uses?

I think it's usually the opposite, you add the function and then the uses separately.

I think I might need this at some point, but for the case I mentioned I have a better idea (http://llvm-reviews.chandlerc.com/D1669)

arsenm abandoned this revision.Mar 9 2016, 9:15 PM

Don't have a current need for this