This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
src/
2/2
thread.cpp

Differential D16634

[libcxx] Whitelist inclusion of sysctl.h instead of blacklisting
ClosedPublic

Authored by bcraig on Jan 27 2016, 8:04 AM.

Download Raw Diff

Details

Reviewers

mclow.lists
ed
jroelofs
jfb

Summary

Instead of excluding all known operating systems that are not derived from BSD, I know include all operating systems that claim to be derived from BSD. Hopefully, that will make it so that this check doesn't need to change for every new operating system that comes along.

Diff Detail

Event Timeline

bcraig updated this revision to Diff 46137.Jan 27 2016, 8:04 AM

bcraig retitled this revision from to [libcxx] Whitelist inclusion of sysctl.h instead of blacklisting.

bcraig updated this object.

bcraig added reviewers: mclow.lists, ed, jfb, jroelofs.

mclow.lists added inline comments.Jan 27 2016, 8:20 AM

src/thread.cpp
22	Where did the `#Include <sys/param.h>` come from?

bcraig added inline comments.Jan 27 2016, 8:44 AM

src/thread.cpp
22	sys/param.h is where BSD is defined (or not). If my research is correct, pretty much every *nix except for CloudABI has a sys/param.h.

bcraig added a subscriber: cfe-commits.Jan 27 2016, 8:45 AM

Added cfe-commits to subscriber list.

This looks fine to me.

This revision is now accepted and ready to land.Jan 27 2016, 8:21 PM

CloudABI doesn't define unix, so stop blacklisting it explicitly and let the whitelist filter it out.

I plan on submitting this tomorrow morning (my time) so that I have lots of time to monitor build failures.

bcraig closed this revision.Jan 29 2016, 6:11 AM

Revision Contents

Path

Size

src/

thread.cpp

11 lines

Diff 46292

src/thread.cpp

Context not available.
	#include "future"	#include "future"
	#include "limits"	#include "limits"
	#include <sys/types.h>	#include <sys/types.h>
	#if !defined(_WIN32)
	# if !defined(__sun__) && !defined(__linux__) && !defined(_AIX) && !defined(__native_client__) && !defined(__CloudABI__)	#if defined(__unix__) \|\| (defined(__APPLE__) && defined(__MACH__))
		# include <sys/param.h>
		# if defined(BSD)
		mclow.listsUnsubmitted Done Reply Inline Actions Where did the `#Include <sys/param.h>` come from? mclow.lists: Where did the `#Include <sys/param.h>` come from?
		bcraigAuthorUnsubmitted Done Reply Inline Actions sys/param.h is where BSD is defined (or not). If my research is correct, pretty much every nix except for CloudABI has a sys/param.h. bcraig:* sys/param.h is where BSD is defined (or not). If my research is correct, pretty much every…
	# include <sys/sysctl.h>	# include <sys/sysctl.h>
	# endif // !defined(__sun__) && !defined(__linux__) && !defined(_AIX) && !defined(__native_client__) && !defined(__CloudABI__)	# endif // defined(BSD)
		#endif // defined(__unix__) \|\| (defined(__APPLE__) && defined(__MACH__))

		#if !defined(_WIN32)
	# include <unistd.h>	# include <unistd.h>
	#endif // !_WIN32	#endif // !_WIN32

Context not available.